Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ML based seed filtering #2709

Merged
merged 43 commits into from
Dec 14, 2023
Merged

feat: ML based seed filtering #2709

merged 43 commits into from
Dec 14, 2023

Conversation

Corentin-Allaire
Copy link
Contributor

@Corentin-Allaire Corentin-Allaire commented Nov 21, 2023 •
edited
Loading

This pull request add a ML based seed selection that can be used to reduce the number of seed after the seeding step.
This PR is pending on the merging of #2690.

@Corentin-Allaire Corentin-Allaire marked this pull request as draft November 21, 2023 16:07
@github-actions github-actions bot added Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Track Finding Ambiguity Resolution labels Nov 21, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2023 •
edited
Loading

📊: Physics performance monitoring for 9297395

Full contents

physmon summary

@andiwand andiwand changed the title feat: Ml seed filtering feat: ML based seed filtering Nov 22, 2023
@Corentin-Allaire Corentin-Allaire marked this pull request as ready for review December 6, 2023 15:45
@paulgessinger paulgessinger added this to the next milestone Dec 6, 2023
@github-actions github-actions bot added the Component - Documentation Affects the documentation label Dec 11, 2023
AJPfleger
AJPfleger requested changes Dec 14, 2023
View reviewed changes
docs/plugins/MLAlgorithms.md Outdated Show resolved Hide resolved
docs/plugins/MLAlgorithms.md Outdated Show resolved Hide resolved
docs/plugins/MLAlgorithms.md Outdated Show resolved Hide resolved
docs/plugins/MLAlgorithms.md Outdated Show resolved Hide resolved
docs/plugins/MLAlgorithms.md Outdated Show resolved Hide resolved
Examples/Scripts/Python/MLAmbiguityResolution/seed_filter_full_chain.py Outdated Show resolved Hide resolved
Examples/Scripts/Python/MLAmbiguityResolution/seed_filter_full_chain.py Outdated Show resolved Hide resolved
Examples/Scripts/Python/MLAmbiguityResolution/seed_filter_full_chain.py Outdated Show resolved Hide resolved
Examples/Scripts/Python/MLAmbiguityResolution/seed_solver_network.py Outdated Show resolved Hide resolved
Examples/Scripts/Python/MLAmbiguityResolution/train_seed_solver.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Component - Core Affects the Core module label Dec 14, 2023
Corentin-Allaire and others added 7 commits December 14, 2023 15:36
@Corentin-Allaire @AJPfleger
Apply suggestions from code review
fa1abc5 
PR sugestions

Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
@Corentin-Allaire @AJPfleger
Apply suggestions from code review
c70cce9 
More sugestions

Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
@Corentin-Allaire
fix doc
52a2d2a
@Corentin-Allaire
Merge remote-tracking branch 'origin/MLSeedFilter' into MLSeedFilter
a962269
@Corentin-Allaire
format
3018e47
@Corentin-Allaire
remove data=data
d94a63f
@Corentin-Allaire
remove print
9297395
@kodiakhq kodiakhq bot merged commit 61bc4e1 into acts-project:main Dec 14, 2023
53 checks passed
@acts-project-service
Copy link
Collaborator

✅ Athena integration test results [61bc4e1]

✅ All tests successful

status job report
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsGSFRefitting.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

@paulgessinger paulgessinger modified the milestones: next, v32.0.0 Jan 19, 2024
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
@Corentin-Allaire @LaraCalic
feat: ML based seed filtering (acts-project#2709)
5e3cbea 
This pull request add a ML based seed selection that can be used to reduce the number of seed after the seeding step.
This PR is pending on the merging of acts-project#2690.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJPfleger AJPfleger AJPfleger approved these changes

Assignees
No one assigned
Labels
Ambiguity Resolution Component - Core Affects the Core module Component - Documentation Affects the documentation Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Track Finding
Projects
None yet
Milestone
v32.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Corentin-Allaire @acts-project-service @AJPfleger @andiwand @paulgessinger