feat: Preliminary work for grouped alignment #2706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2706 +/- ##
=======================================
Coverage 48.85% 48.85%
=======================================
Files 490 490
Lines 28518 28518
Branches 13480 13480
=======================================
Hits 13933 13933
Misses 4861 4861
Partials 9724 9724 ☔ View full report in Codecov by Sentry. |
apparently otherwise the random engine can be different on different platforms which I observed in acts-project#2625 with macos at the same time I hardcoded the type for the `std::uniform_int_distribution`. apparently this can also make a difference for the random value
LaraCalic
force-pushed
the
alignment_group
branch
from
a9ae0b3 to
0aa19a9
Compare
📊: Physics performance monitoring for 24358f5physmon summary
|
Examples/Algorithms/Alignment/include/ActsExamples/Alignment/AlignmentAlgorithm.hpp
Show resolved
Hide resolved
paulgessinger
previously approved these changes
Jan 16, 2024
Examples/Algorithms/Alignment/include/ActsExamples/Alignment/AlignmentAlgorithm.hpp
Show resolved
Hide resolved
|
I added @LaraCalic to the CI allowlist now. Can either on of you push an empty commit to trigger the pipeline again? |
acts-policybot
bot
dismissed
paulgessinger’s stale review
Invalidated by push of 24358f5
|
Done @paulgessinger but you will need to reaprove! |
paulgessinger
approved these changes
Jan 17, 2024
acts-project-service
added
the
Breaks Athena build
|
Athena failure is unrelated to this PR. |
LaraCalic
added a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
This PR contains preliminary work on the superstructure alignment mechanism. It contains a GeometryHiearchyList-based grouping mechanism courtesy of @LaraCalic and simple unit tests by me. Co-authored-by: Lara Calic <81815115+LaraCalic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains preliminary work on the superstructure alignment mechanism. It contains a GeometryHiearchyList-based grouping mechanism courtesy of @LaraCalic and simple unit tests by me.