-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update support surface building #2879
feat: update support surface building #2879
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2879 +/- ##
==========================================
- Coverage 48.98% 48.90% -0.08%
==========================================
Files 494 494
Lines 28742 28822 +80
Branches 13606 13668 +62
==========================================
+ Hits 14078 14095 +17
- Misses 4854 4874 +20
- Partials 9810 9853 +43 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 59cfb15physmon summary
|
Hi @Corentin-Allaire - I requested this one for you. This is the way how to automatically build support (i.e. passive) material surfaces in the new geometry model, you can tell via a I will have a follow-up PR which shows this on the Open Data Detector. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me ! I have noted some small mistake in the comments but except from that it looks good
Co-authored-by: Corentin ALLAIRE <62873125+Corentin-Allaire@users.noreply.github.com>
Co-authored-by: Corentin ALLAIRE <62873125+Corentin-Allaire@users.noreply.github.com>
|
This PR sits on top of #2879 and uses the new `ProtoBinning`, `ProtoMaterial` and `ProtoSupport` schema within the DD4hep context. It allows to assign `ProtoBinning` to translated support surfaces, but also to define support via DD4hep. This is the first part of this, a dedicated filling of `acts_proto_support` will follow in a second PR.
This PR: - changes how the definition of `ProtoSupport` is done - renames the `SupportHelper` to `SupportSurfacesHelper` - adds rectangular support shapes to `SupportSurfacesHelper` and `LayerStructureBuilder` - extends the Unit tests --------- Co-authored-by: Corentin ALLAIRE <62873125+Corentin-Allaire@users.noreply.github.com>
This PR sits on top of acts-project#2879 and uses the new `ProtoBinning`, `ProtoMaterial` and `ProtoSupport` schema within the DD4hep context. It allows to assign `ProtoBinning` to translated support surfaces, but also to define support via DD4hep. This is the first part of this, a dedicated filling of `acts_proto_support` will follow in a second PR.
This PR:
ProtoSupport
is doneSupportHelper
toSupportSurfacesHelper
SupportSurfacesHelper
andLayerStructureBuilder