Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dd4hep allow proto material #2889

Merged

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented Jan 23, 2024

This PR sits on top of #2879 and uses the new ProtoBinning, ProtoMaterial and ProtoSupport schema within the DD4hep context.

It allows to assign ProtoBinning to translated support surfaces, but also to define support via DD4hep.

This is the first part of this, a dedicated filling of acts_proto_support will follow in a second PR.

@asalzburger asalzburger added the 🛑 blocked This item is blocked by another item label Jan 23, 2024
@asalzburger asalzburger added this to the next milestone Jan 23, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Plugins Affects one or more Plugins labels Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6aeeeda) 48.92% compared to head (6995086) 48.92%.
Report is 1 commits behind head on main.

❗ Current head 6995086 differs from pull request most recent head 945cc17. Consider uploading reports for the commit 945cc17 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2889      +/-   ##
==========================================
- Coverage   48.92%   48.92%   -0.01%     
==========================================
  Files         496      496              
  Lines       28855    28849       -6     
  Branches    13680    13677       -3     
==========================================
- Hits        14118    14113       -5     
- Misses       4873     4874       +1     
+ Partials     9864     9862       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the Component - Examples Affects the Examples module label Jan 24, 2024
@asalzburger asalzburger requested a review from dimitra97 January 25, 2024 08:01
@asalzburger
Copy link
Contributor Author

Hi @dimitra97 - this PR is super small, should be quick to be reviewed.

@asalzburger asalzburger removed the 🛑 blocked This item is blocked by another item label Jan 25, 2024
Copy link
Contributor

@dimitra97 dimitra97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small suggestion/wondering

Plugins/DD4hep/src/DD4hepBlueprintFactory.cpp Outdated Show resolved Hide resolved
@asalzburger asalzburger requested a review from dimitra97 January 25, 2024 14:05
Copy link
Contributor

@dimitra97 dimitra97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approving!

@kodiakhq kodiakhq bot merged commit fb92e4c into acts-project:main Jan 29, 2024
53 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jan 29, 2024
@paulgessinger paulgessinger modified the milestones: next, v32.1.0 Feb 2, 2024
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
This PR sits on top of acts-project#2879 and uses the new `ProtoBinning`, `ProtoMaterial` and `ProtoSupport` schema within the DD4hep context.

It allows to assign `ProtoBinning` to translated support surfaces, but also to define support via DD4hep.

This is the first part of this, a dedicated filling of `acts_proto_support` will follow in a second PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants