-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dd4hep allow proto material #2889
feat: dd4hep allow proto material #2889
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
==========================================
- Coverage 48.92% 48.92% -0.01%
==========================================
Files 496 496
Lines 28855 28849 -6
Branches 13680 13677 -3
==========================================
- Hits 14118 14113 -5
- Misses 4873 4874 +1
+ Partials 9864 9862 -2 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 945cc17physmon summary
|
Hi @dimitra97 - this PR is super small, should be quick to be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a small suggestion/wondering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Approving!
🔴 Athena integration test results🔴 Some tests have failed!Please investigate the pipeline! |
This PR sits on top of acts-project#2879 and uses the new `ProtoBinning`, `ProtoMaterial` and `ProtoSupport` schema within the DD4hep context. It allows to assign `ProtoBinning` to translated support surfaces, but also to define support via DD4hep. This is the first part of this, a dedicated filling of `acts_proto_support` will follow in a second PR.
This PR sits on top of #2879 and uses the new
ProtoBinning
,ProtoMaterial
andProtoSupport
schema within the DD4hep context.It allows to assign
ProtoBinning
to translated support surfaces, but also to define support via DD4hep.This is the first part of this, a dedicated filling of
acts_proto_support
will follow in a second PR.