-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Geometry-agnostic material mapping for both surfaces and volumes #2935
Closed
ssdetlab
wants to merge
25
commits into
acts-project:main
from
ssdetlab:agnostic-surface-material-mapping
Closed
feat: Geometry-agnostic material mapping for both surfaces and volumes #2935
ssdetlab
wants to merge
25
commits into
acts-project:main
from
ssdetlab:agnostic-surface-material-mapping
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
labels
Feb 7, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2935 +/- ##
==========================================
+ Coverage 48.87% 49.14% +0.26%
==========================================
Files 495 496 +1
Lines 28904 28965 +61
Branches 13722 13730 +8
==========================================
+ Hits 14128 14234 +106
+ Misses 4883 4741 -142
- Partials 9893 9990 +97 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for b6bd5e7physmon summary
|
ssdetlab
changed the title
feat: Agnostic surface material mapping
feat: Geometry-agnostic material mapping for both surfaces and volumes
Feb 13, 2024
Separated the Navigator part into the #2988 Closing for now, will come back later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes Performance
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to finish the work started by the #2473
In addition to the changes described in the original PR:
Support of both the
TrackingGeometry
Navigator
and theDetectorNavigator
in bothSurfaceMaterialMapper
andVolumeMaterialMapper
is implemented.Volume material mapping is finished with conversion of the
VolumeHit
struct into something that can support both the geometries for the time being. Now it is inheriting from theInteractionVolume
which already has some infrastructure for theDetector
/TrackingGeometry
switching. Slight renaming is introduced.Minor fixes in Python bindings are made. The segfault problem of the original PR is resolved. Root hashes were modified due to the renaming of the output files.
Modifications are made to the
DetectorNavigator
to resolve the problem of stepping loop abortion before the first step is even made, and the problem of exiting the stepping loop due to theVolumeBounds::inside()
returning true when the stepper just exited thePortal
and is on the verge of the volume. The latter prevented End Of World check from executing correctly. These are, most likely, temporary solutions, as it feels that something smarter can be done there.Unit Tests are expanded for both Volume and Surface material mapping.