feat: introduce material accumulation interface (MM3) #3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for bcf5f36physmon summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
==========================================
+ Coverage 49.02% 49.13% +0.10%
==========================================
Files 494 498 +4
Lines 29058 29077 +19
Branches 13797 13795 -2
==========================================
+ Hits 14246 14287 +41
+ Misses 4929 4905 -24
- Partials 9883 9885 +2 ☔ View full report in Codecov by Sentry. |
asalzburger
force-pushed
the
feat-mm3-accumulation
branch
from
c9fc409 to
df7774a
Compare
Core/include/Acts/Material/interface/ISurfaceMaterialAccumulater.hpp
Outdated
Show resolved
Hide resolved
|
Comments should be addressed now. |
Corentin-Allaire
previously approved these changes
Apr 8, 2024
acts-policybot
bot
dismissed
Corentin-Allaire’s stale review
Invalidated by push of 15acf61
Corentin-Allaire
approved these changes
Apr 8, 2024
🔴 Athena integration test results [6a36ee4]🔴 Some tests have failed!Please investigate the pipeline! |
acts-project-service
added
the
Fails Athena tests
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Apr 19, 2024
) This is the first PR in a series that divides the Material Mapping into logical, unit testable modules: 1) Finding intersections with surfaces and associations to volumes (MM2) 2) Assigning material interactions to those intersections (MM1) 3) Mapping those onto dedicated Surface / Volume Material Mappers (MM3, this PR, partly) 4) Steer that by a chained algorithm (MM4) This PR: It encapsulates the pure accumulation of the material for Surface based materials into a new module. The accumulation is now decoupled from the association, i.e. one can run the mapping with a navigator or with a trial and error method, and still use the exact same material mapper. The code is largely transferred from the 'SurfaceMaterialMapper' which will vanish to exist after this re-organization. @Corentin-Allaire - the State of this Mapper would have all the access to run the optimisation, I have not yet re-introduced the track variance, but that should be a five-line change. This PR is blocked by acts-project#3015 and acts-project#3016. All cases are showcased and tested in a set of UnitTests.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
) This is the first PR in a series that divides the Material Mapping into logical, unit testable modules: 1) Finding intersections with surfaces and associations to volumes (MM2) 2) Assigning material interactions to those intersections (MM1) 3) Mapping those onto dedicated Surface / Volume Material Mappers (MM3, this PR, partly) 4) Steer that by a chained algorithm (MM4) This PR: It encapsulates the pure accumulation of the material for Surface based materials into a new module. The accumulation is now decoupled from the association, i.e. one can run the mapping with a navigator or with a trial and error method, and still use the exact same material mapper. The code is largely transferred from the 'SurfaceMaterialMapper' which will vanish to exist after this re-organization. @Corentin-Allaire - the State of this Mapper would have all the access to run the optimisation, I have not yet re-introduced the track variance, but that should be a five-line change. This PR is blocked by acts-project#3015 and acts-project#3016. All cases are showcased and tested in a set of UnitTests.
asalzburger
added a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
) This is the first PR in a series that divides the Material Mapping into logical, unit testable modules: 1) Finding intersections with surfaces and associations to volumes (MM2) 2) Assigning material interactions to those intersections (MM1) 3) Mapping those onto dedicated Surface / Volume Material Mappers (MM3, this PR, partly) 4) Steer that by a chained algorithm (MM4) This PR: It encapsulates the pure accumulation of the material for Surface based materials into a new module. The accumulation is now decoupled from the association, i.e. one can run the mapping with a navigator or with a trial and error method, and still use the exact same material mapper. The code is largely transferred from the 'SurfaceMaterialMapper' which will vanish to exist after this re-organization. @Corentin-Allaire - the State of this Mapper would have all the access to run the optimisation, I have not yet re-introduced the track variance, but that should be a five-line change. This PR is blocked by acts-project#3015 and acts-project#3016. All cases are showcased and tested in a set of UnitTests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR in a series that divides the Material Mapping into logical, unit testable modules:
This PR:
It encapsulates the pure accumulation of the material for Surface based materials into a new module. The accumulation is now decoupled from the association, i.e. one can run the mapping with a navigator or with a trial and error method, and still use the exact same material mapper.
The code is largely transferred from the 'SurfaceMaterialMapper' which will vanish to exist after this re-organization.
@Corentin-Allaire - the State of this Mapper would have all the access to run the optimisation, I have not yet re-introduced the track variance, but that should be a five-line change.
This PR is blocked by #3015 and #3016.
All cases are showcased and tested in a set of UnitTests.