-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: MaterialMapper in Core (MM4) #3021
Closed
asalzburger
wants to merge
19
commits into
acts-project:main
from
asalzburger:feat-core-material-mapper-mm4
Closed
feat: MaterialMapper in Core (MM4) #3021
asalzburger
wants to merge
19
commits into
acts-project:main
from
asalzburger:feat-core-material-mapper-mm4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for 8cecc7bphysmon summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3021 +/- ##
==========================================
+ Coverage 48.86% 49.01% +0.15%
==========================================
Files 493 503 +10
Lines 29058 29352 +294
Branches 13798 13959 +161
==========================================
+ Hits 14200 14388 +188
+ Misses 4962 4932 -30
- Partials 9896 10032 +136 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR in a series that divides the Material Mapping into logical, unit testable modules:
This PR:
Introduces a MaterialMapper which just needs I/O connection in the relevant framework/experiment context implementation.
This PR is blocked by #3015 , #3016 and #3020.
All cases are showcased and tested in a set of UnitTests.