Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MaterialMapper in Core (MM4) #3021

Closed

Conversation

asalzburger
Copy link
Contributor

This is the first PR in a series that divides the Material Mapping into logical, unit testable modules:

  1. Finding intersections with surfaces and associations to volumes (MM2)
  2. Assigning material interactions to those intersections (MM1)
  3. Mapping those onto dedicated Surface / Volume Material Mappers (MM3)
  4. Steer that by a chained algorithm (MM4, this PR)

This PR:

Introduces a MaterialMapper which just needs I/O connection in the relevant framework/experiment context implementation.

This PR is blocked by #3015 , #3016 and #3020.

All cases are showcased and tested in a set of UnitTests.

@asalzburger asalzburger added this to the next milestone Mar 11, 2024
@asalzburger asalzburger added the 🛑 blocked This item is blocked by another item label Mar 11, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label Mar 11, 2024
@asalzburger asalzburger marked this pull request as draft March 11, 2024 15:22
@asalzburger asalzburger marked this pull request as ready for review March 11, 2024 15:33
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 53.47985% with 127 lines in your changes are missing coverage. Please review.

Project coverage is 49.01%. Comparing base (6507d84) to head (8cecc7b).

Files Patch % Lines
.../src/Material/BinnedSurfaceMaterialAccumulater.cpp 48.64% 4 Missing and 34 partials ⚠️
Core/src/Material/IntersectionMaterialAssigner.cpp 43.39% 3 Missing and 27 partials ⚠️
...ore/src/Material/MaterialInteractionAssignment.cpp 51.72% 0 Missing and 28 partials ⚠️
...clude/Acts/Material/PropagatorMaterialAssigner.hpp 45.45% 1 Missing and 17 partials ⚠️
Core/src/Material/MaterialMapper.cpp 72.72% 0 Missing and 12 partials ⚠️
...ude/Acts/Material/IntersectionMaterialAssigner.hpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3021      +/-   ##
==========================================
+ Coverage   48.86%   49.01%   +0.15%     
==========================================
  Files         493      503      +10     
  Lines       29058    29352     +294     
  Branches    13798    13959     +161     
==========================================
+ Hits        14200    14388     +188     
+ Misses       4962     4932      -30     
- Partials     9896    10032     +136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asalzburger asalzburger closed this Apr 8, 2024
@andiwand andiwand modified the milestones: next, v34.1.0 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module 🛑 blocked This item is blocked by another item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants