-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improved debugging outputs for GainMatrixSmoother
#3077
chore: Improved debugging outputs for GainMatrixSmoother
#3077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How often do we encounter this branch normally? Why don't we set it as ACTS_DEBUG
or ACTS_VERBOSE
, then we don't need to toggle it manually.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3077 +/- ##
==========================================
- Coverage 49.05% 49.04% -0.02%
==========================================
Files 494 494
Lines 28973 28979 +6
Branches 13740 13746 +6
==========================================
Hits 14214 14214
- Misses 4923 4929 +6
Partials 9836 9836 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for a97650aphysmon summary
|
Sure - changed it to verbose log In practice this should not happen often but if the input is wrong in the first place it will most likely happen |
…ect#3077) IMO useful debugging logs
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and removing earlier test (`MyTrackFindingAlgorithm`). blocked by - acts-project#3074 - acts-project#3075 - acts-project#3076 - acts-project#3077 - acts-project#3078 - acts-project#3086 --------- Co-authored-by: andiwand <stefl.andreas@gmail.com> Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
…ect#3077) IMO useful debugging logs
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and removing earlier test (`MyTrackFindingAlgorithm`). blocked by - acts-project#3074 - acts-project#3075 - acts-project#3076 - acts-project#3077 - acts-project#3078 - acts-project#3086 --------- Co-authored-by: andiwand <stefl.andreas@gmail.com> Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
…ect#3077) IMO useful debugging logs
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and removing earlier test (`MyTrackFindingAlgorithm`). blocked by - acts-project#3074 - acts-project#3075 - acts-project#3076 - acts-project#3077 - acts-project#3078 - acts-project#3086 --------- Co-authored-by: andiwand <stefl.andreas@gmail.com> Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
IMO useful debugging logs