Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improved debugging outputs for GainMatrixSmoother #3077

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Apr 4, 2024

IMO useful debugging logs

@andiwand andiwand added this to the next milestone Apr 4, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Track Fitting labels Apr 4, 2024
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How often do we encounter this branch normally? Why don't we set it as ACTS_DEBUG or ACTS_VERBOSE, then we don't need to toggle it manually.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 49.04%. Comparing base (b0c64a0) to head (a97650a).

Files Patch % Lines
Core/src/TrackFitting/GainMatrixSmoother.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3077      +/-   ##
==========================================
- Coverage   49.05%   49.04%   -0.02%     
==========================================
  Files         494      494              
  Lines       28973    28979       +6     
  Branches    13740    13746       +6     
==========================================
  Hits        14214    14214              
- Misses       4923     4929       +6     
  Partials     9836     9836              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andiwand
Copy link
Contributor Author

andiwand commented Apr 4, 2024

How often do we encounter this branch normally? Why don't we set it as ACTS_DEBUG or ACTS_VERBOSE, then we don't need to toggle it manually.

Sure - changed it to verbose log

In practice this should not happen often but if the input is wrong in the first place it will most likely happen

@kodiakhq kodiakhq bot merged commit 9c8141e into acts-project:main Apr 4, 2024
52 checks passed
@github-actions github-actions bot removed the automerge label Apr 4, 2024
@andiwand andiwand deleted the chore-gain-matrix-smoother-debugging-outputs branch April 4, 2024 16:43
andiwand added a commit that referenced this pull request Apr 11, 2024
Resurrect #2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- #3074
- #3075
- #3076
- #3077
- #3078
- #3086

---------

Co-authored-by: andiwand <stefl.andreas@gmail.com>
Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
@andiwand andiwand modified the milestones: next, v34.0.0 Apr 15, 2024
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- acts-project#3074
- acts-project#3075
- acts-project#3076
- acts-project#3077
- acts-project#3078
- acts-project#3086

---------

Co-authored-by: andiwand <stefl.andreas@gmail.com>
Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- acts-project#3074
- acts-project#3075
- acts-project#3076
- acts-project#3077
- acts-project#3078
- acts-project#3086

---------

Co-authored-by: andiwand <stefl.andreas@gmail.com>
Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- acts-project#3074
- acts-project#3075
- acts-project#3076
- acts-project#3077
- acts-project#3078
- acts-project#3086

---------

Co-authored-by: andiwand <stefl.andreas@gmail.com>
Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants