Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Do not allocate smoothed track state components in CKF #3086

Merged
merged 2 commits into from
Apr 9, 2024
Merged

refactor: Do not allocate smoothed track state components in CKF #3086

merged 2 commits into from
Apr 9, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Apr 8, 2024

Since the CKF is not responsible for smoothing anymore it should not allocate these components on the track state. #2722

@andiwand andiwand added this to the next milestone Apr 8, 2024
@andiwand andiwand mentioned this pull request Apr 8, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024 •
edited
Loading

📊: Physics performance monitoring for e1af120

Full contents

physmon summary

@acts-project-service
Copy link
Collaborator

acts-project-service commented Apr 8, 2024 •
edited
Loading

✅ Athena integration test results [e22fef9]

✅ All tests successful

status job report
🟢 run_unit_tests
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsConversionWorkflow
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

@acts-project-service acts-project-service added Fails Athena tests This PR causes a failure in the Athena tests Breaks Athena build This PR breaks the Athena build labels Apr 8, 2024
@andiwand andiwand removed Breaks Athena build This PR breaks the Athena build Fails Athena tests This PR causes a failure in the Athena tests labels Apr 8, 2024
@kodiakhq kodiakhq bot merged commit e22fef9 into acts-project:main Apr 9, 2024
51 checks passed
@github-actions github-actions bot removed the automerge label Apr 9, 2024
@andiwand andiwand deleted the refactor-ckf-no-smoothed branch April 9, 2024 11:16
andiwand added a commit that referenced this pull request Apr 11, 2024
@timadye @andiwand
feat: Two-way CKF example (#3066)
d1f4939 
Resurrect #2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- #3074
- #3075
- #3076
- #3077
- #3078
- #3086

---------

Co-authored-by: andiwand <stefl.andreas@gmail.com>
Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
@andiwand andiwand modified the milestones: next, v34.0.0 Apr 15, 2024
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
@andiwand @Ragansu
refactor: Do not allocate smoothed track state components in CKF (act…
e51428a 
…s-project#3086)

Since the CKF is not responsible for smoothing anymore it should not allocate these components on the track state. acts-project#2722
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
@timadye @andiwand @Ragansu
feat: Two-way CKF example (acts-project#3066)
fff2c61 
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- acts-project#3074
- acts-project#3075
- acts-project#3076
- acts-project#3077
- acts-project#3078
- acts-project#3086

---------

Co-authored-by: andiwand <stefl.andreas@gmail.com>
Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
@andiwand @EleniXoch
refactor: Do not allocate smoothed track state components in CKF (act…
c991872 
…s-project#3086)

Since the CKF is not responsible for smoothing anymore it should not allocate these components on the track state. acts-project#2722
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
@timadye @andiwand @EleniXoch
feat: Two-way CKF example (acts-project#3066)
305a098 
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- acts-project#3074
- acts-project#3075
- acts-project#3076
- acts-project#3077
- acts-project#3078
- acts-project#3086

---------

Co-authored-by: andiwand <stefl.andreas@gmail.com>
Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
@andiwand @asalzburger
refactor: Do not allocate smoothed track state components in CKF (act…
8dc9828 
…s-project#3086)

Since the CKF is not responsible for smoothing anymore it should not allocate these components on the track state. acts-project#2722
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
@timadye @andiwand @asalzburger
feat: Two-way CKF example (acts-project#3066)
68838b2 
Resurrect acts-project#2717 from @andiwand, updating to the latest `main`, and
removing earlier test (`MyTrackFindingAlgorithm`).

blocked by
- acts-project#3074
- acts-project#3075
- acts-project#3076
- acts-project#3077
- acts-project#3078
- acts-project#3086

---------

Co-authored-by: andiwand <stefl.andreas@gmail.com>
Co-authored-by: Tim Adye <Tim.Adye@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJPfleger AJPfleger AJPfleger approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Event Data Model Track Finding Track Fitting
Projects
None yet
Milestone
v34.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andiwand @acts-project-service @AJPfleger