refactor: Rework random parameter and covariance generation #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andiwand
commented
Oct 23, 2024
andiwand
commented
- Reworks random bound and free track parameter generation
- This should guarantee to obtain valid parameters feat: Validate track parameters #3756
- Split general random parameter and covariance generation
- Also, don't use covariance to draw parameters in general random generation
github-actions
bot
added
Component - Core
paulgessinger
previously approved these changes
Oct 24, 2024
Examples/Algorithms/Generators/ActsExamples/Generators/ParametricParticleGenerator.cpp
Show resolved
Hide resolved
paulgessinger
previously approved these changes
Oct 24, 2024
acts-policybot
bot
dismissed
paulgessinger’s stale review
Invalidated by push of 2c3a682
paulgessinger
approved these changes
Oct 24, 2024
|
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
Adds two free functions which allow checking `BoundVector`s and `FreeVectors`s for valid track parameters. This is then used as `assert`s in the track parameter EDM. blocked by - #3777
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
…ject#3777) - Reworks random bound and free track parameter generation - This should guarantee to obtain valid parameters acts-project#3756 - Split general random parameter and covariance generation - Also, don't use covariance to draw parameters in general random generation
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
Adds two free functions which allow checking `BoundVector`s and `FreeVectors`s for valid track parameters. This is then used as `assert`s in the track parameter EDM. blocked by - acts-project#3777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.