feat: Validate track parameters #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
|
0a02484 contains your feedback @paulgessinger |
|
This fires basically everywhere. It would take quite some time to fix every single problem. I think we can just add the functionality and not assert on it for now. The question is if we really want to assert on it. $\phi $ being out of range usually does not hurt. With |
|
This is a bit frustrating: we have a bunch of invalid track parameters in the code which are generated randomly in different ways. I think it would be good to have one mechanism of generating random track parameters which has to be parameterized before we can continue with this PR. |
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
- Reworks random bound and free track parameter generation - This should guarantee to obtain valid parameters #3756 - Split general random parameter and covariance generation - Also, don't use covariance to draw parameters in general random generation
timadye
reviewed
Oct 25, 2024
timadye
reviewed
Oct 25, 2024
paulgessinger
approved these changes
Oct 29, 2024
paulgessinger
approved these changes
Oct 29, 2024
|
acts-project-service
added
the
Fails Athena tests
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
…ject#3777) - Reworks random bound and free track parameter generation - This should guarantee to obtain valid parameters acts-project#3756 - Split general random parameter and covariance generation - Also, don't use covariance to draw parameters in general random generation
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
Adds two free functions which allow checking `BoundVector`s and `FreeVectors`s for valid track parameters. This is then used as `assert`s in the track parameter EDM. blocked by - acts-project#3777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two free functions which allow checking
BoundVectors andFreeVectorss for valid track parameters. This is then used asasserts in the track parameter EDM.blocked by