Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: path creation #739

Merged
merged 1 commit into from
May 27, 2024
Merged

fix: path creation #739

merged 1 commit into from
May 27, 2024

Conversation

niermann999
Copy link
Contributor

The is_directory call does not seem to work as expected, so only actual directory paths must be passed to create_path.

@niermann999 niermann999 added bug Something isn't working priority: high high priority labels May 27, 2024
@niermann999 niermann999 requested a review from krasznaa May 27, 2024 14:02
@niermann999 niermann999 mentioned this pull request May 27, 2024
Merged
krasznaa
krasznaa approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, this looks straight forward enough. 👍

@niermann999 niermann999 merged commit 3f5afb3 into acts-project:main May 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krasznaa krasznaa krasznaa approved these changes

Assignees
No one assigned
Labels
bug Something isn't working priority: high high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niermann999 @krasznaa