ref: Update to detray version 66.1 #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
force-pushed
the
ref-update-detray
branch
from
5876fd2 to
ed9b816
Compare
krasznaa
approved these changes
May 27, 2024
| /// @param cfg The configuration object to fill | ||
| /// | ||
| void setup(detray::propagation::config<double>& cfg) const; | ||
| void setup(detray::propagation::config& cfg) const; |
There was a problem hiding this comment.
You could actually simplify this code even a bit further. 🤔
I introduced this setup(...) function in #542, to hack around the template parameter of detray::propagation::config. Now that the type is not templated, we could get rid of this function completely, undoing 752ae64. Would you be up for that? 😄
There was a problem hiding this comment.
Done. I also let detray print the propagation options now.
This PR needs an additional fix from detray to go in first:
acts-project/detray#739
niermann999
force-pushed
the
ref-update-detray
branch
from
ed9b816 to
8d2f62c
Compare
niermann999
force-pushed
the
ref-update-detray
branch
from
8d2f62c to
eb5d627
Compare
niermann999
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: cuda navigation validation by @niermann999 in #732
oneAPI 2024.1.0 Support, main branch (2024.05.15.) by @krasznaa in #734
feat: Add simd intersectors and benchmark them by @niermann999 in #712
feat: Move material maps generation to factory, add material maps to new toy detector and remove old toy detector by @niermann999 in #709
ref: Allow printing of propagation config and remove templates by @niermann999 in #718
Update README.md by @beomki-yeo in #737
fix: navigation and make mask tolerance scaling configurable by @niermann999 in #738