-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower the values of qop stddevs #720
Lower the values of qop stddevs #720
Conversation
Sure, no objections here. Let me know once it goes out of draft status. |
Yup, but it seems there is a fundamental problem deeper inside - investigating.. |
c1c24ac
to
2803acb
Compare
When the qop of initial track parameter gets very small (~0.001) by the high stddev, the sign of qop can change in the kalman updater. While the exact reason is unknown, I guess that the high deviation from truth value causes kalman fitter to make large numerical uncertainties. |
2803acb
to
fa70a58
Compare
Actually the stddev of q/p need to be given as something like 10% of truth q/p instead of a hard coded value. (Current examples will still break for >1000 GeV/c particles) But let's do that in the later PR |
@krasznaa review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust your judgement on this.
Quality Gate passedIssues Measures |
The current stddev of qop is high which can change the sign of qop. This PR lowers the values of qop stddevs.