Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower the values of qop stddevs #720

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

beomki-yeo
Copy link
Contributor

The current stddev of qop is high which can change the sign of qop. This PR lowers the values of qop stddevs.

@beomki-yeo beomki-yeo marked this pull request as draft October 1, 2024 14:54
@krasznaa
Copy link
Member

krasznaa commented Oct 1, 2024

Sure, no objections here. Let me know once it goes out of draft status.

@beomki-yeo
Copy link
Contributor Author

Yup, but it seems there is a fundamental problem deeper inside - investigating..

@beomki-yeo beomki-yeo force-pushed the fix-truth-fitting-stddevs branch from c1c24ac to 2803acb Compare October 1, 2024 18:11
@beomki-yeo beomki-yeo marked this pull request as ready for review October 1, 2024 18:11
@beomki-yeo
Copy link
Contributor Author

When the qop of initial track parameter gets very small (~0.001) by the high stddev, the sign of qop can change in the kalman updater.

While the exact reason is unknown, I guess that the high deviation from truth value causes kalman fitter to make large numerical uncertainties.

@beomki-yeo beomki-yeo force-pushed the fix-truth-fitting-stddevs branch from 2803acb to fa70a58 Compare October 1, 2024 18:33
@beomki-yeo
Copy link
Contributor Author

Actually the stddev of q/p need to be given as something like 10% of truth q/p instead of a hard coded value. (Current examples will still break for >1000 GeV/c particles) But let's do that in the later PR

@beomki-yeo
Copy link
Contributor Author

@krasznaa review?

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust your judgement on this.

Copy link

sonarqubecloud bot commented Oct 4, 2024

@krasznaa krasznaa merged commit 5eda9c8 into acts-project:main Oct 4, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants