Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower the values of qop stddevs #720

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Lower the values of qop stddevs #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa70a58
Lower the value of qop stddevs
beomki-yeo Oct 1, 2024
0b19a9a
Merge branch 'main' into fix-truth-fitting-stddevs
beomki-yeo Oct 4, 2024
6195535
Merge branch 'main' into fix-truth-fitting-stddevs
beomki-yeo Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/include/traccc/fitting/kalman_filter/gain_matrix_updater.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,12 @@ struct gain_matrix_updater {
const matrix_type<1, 1> chi2 = matrix_operator().transpose(residual) *
matrix_operator().inverse(R) * residual;

// Make sure that the sign of qop does not change (This rarely happens
// when qop is set with a poor seed resolution)
assert(bound_params[e_bound_qoverp] *
getter::element(filtered_vec, e_bound_qoverp, 0u) >
0.f);

// Set the stepper parameter
bound_params.set_vector(filtered_vec);
bound_params.set_covariance(filtered_cov);
Expand Down
2 changes: 1 addition & 1 deletion examples/run/cpu/truth_fitting_example.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ int main(int argc, char* argv[]) {
0.03f * detray::unit<scalar>::mm,
0.017f,
0.017f,
0.01f / detray::unit<scalar>::GeV,
0.001f / detray::unit<scalar>::GeV,
1.f * detray::unit<scalar>::ns};

// Fitting algorithm object
Expand Down
2 changes: 1 addition & 1 deletion examples/run/cuda/truth_fitting_example_cuda.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ int main(int argc, char* argv[]) {
0.03f * detray::unit<scalar>::mm,
0.017f,
0.017f,
0.01f / detray::unit<scalar>::GeV,
0.001f / detray::unit<scalar>::GeV,
1.f * detray::unit<scalar>::ns};

// Fitting algorithm object
Expand Down
2 changes: 1 addition & 1 deletion tests/common/tests/kalman_fitting_toy_detector_test.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class KalmanFittingToyDetectorTests : public KalmanFittingTests {
0.01f * detray::unit<scalar>::mm,
0.001f,
0.001f,
0.01f / detray::unit<scalar>::GeV,
0.001f / detray::unit<scalar>::GeV,
0.01f * detray::unit<scalar>::ns};

protected:
Expand Down
Loading