Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a typescript compatible linter setup #110

Closed
wants to merge 6 commits into from
Closed

Add a typescript compatible linter setup #110

wants to merge 6 commits into from

Conversation

TomAFrench
Copy link
Contributor

@TomAFrench TomAFrench commented Jun 30, 2022 •
edited
Loading

For a PR which adds a TS compatible linter which is a necessary prerequisite for #84 as we need a linter which can process typescript files.

Plus as a bonus we get rid of a babel dependency.

@TomAFrench
Copy link
Contributor Author

TomAFrench commented Jun 30, 2022 •
edited
Loading

I've had to leave desktop-client on the old linting setup as updating eslint causes eslint-loader to fail. Updating eslint-loader causes issues with jwl-dev-utils/InlineChunkHtmlPlugin (James W. Long dev utils?) and what started as swapping out a linter turns into unravelling the whole jumper. To progress on this I think we'd need to talk on why we're using a vendored version of these utils to see how to progress.

@TomAFrench TomAFrench mentioned this pull request Jul 8, 2022
Closed
@TomAFrench TomAFrench mentioned this pull request Jul 17, 2022
Merged
@TomAFrench
Copy link
Contributor Author

Marking this as draft as it's blocked by #132

@TomAFrench TomAFrench marked this pull request as draft July 20, 2022 00:53
@TomAFrench TomAFrench mentioned this pull request Jul 31, 2022
Closed
@TomAFrench
Copy link
Contributor Author

Superceded by #142

@TomAFrench TomAFrench closed this Jul 31, 2022
oleksandr pushed a commit to oleksandr/actual that referenced this pull request Dec 30, 2023
@dependabot
build(deps): bump node-fetch from 2.2.0 to 2.6.7 (actualbudget#110)
24da9b7 
Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.2.0 to 2.6.7.
- [Release notes](https://github.com/node-fetch/node-fetch/releases)
- [Commits](node-fetch/node-fetch@v2.2.0...v2.6.7)

---
updated-dependencies:
- dependency-name: node-fetch
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TomAFrench