-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal typescript migration #84
Conversation
Converting to draft as this currently blows up running tests in loot-core as |
Have you considered renaming everything to |
Doing that would destroy information on which files have had a meaningful migration over to typescript. We'd also be requiring those other files to pass the type checks which they likely would fail ( It'd also add a ton of noise to the PR so if we were to do that I'd prefer to do it as a separate PR, my preference though is to migrate to |
Closing this PR as stale. Someone else can pick up the work started here and continue it in a new PR. |
This PR performs an MVP migration of
loot-core
over to typescript:ts-loader
has been added to the webpack config so that it can load TS filesmain.js
has been replaced bymain.ts
.loot-core
package to build.This allows us to gradually migrate the rest of the package over to typescript without having to do everything at once (causing huge merge conflicts with the other PRs). Considering how widely
loot-core
is used across the other packages, I think it makes sense to migrate this package first and once it has a well defined interface then we can migrate the other packages over to TS.One odd thing I've noticed is that we've set the context for the
loot-core
package to be the monorepo root which seems to cause a need forts-loader
to be installed up there (or at the very least hoisted). I haven't looked into whether this is necessary or if we can remove this.