Make frequency selection work as designed #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncy table in the header file. Without this, #define-ing a frequency in the sketch has no effect, because that same #define is not present when the library is compiled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By initializing the frequency table in the header file. Without this, #define-ing a frequency in the sketch has no effect, because that same #define is not present when the library is compiled.
This is one of the options to fix this, but it's not my preferred option - I'll send a PR for my preferred option momentarily.
This option has the advantage that it maintains compatibility with what was previously documented to work - but since that didn't actually work, that's probably of limited value - nobody can have been using it.