Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding EPD Feather #3

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Adding EPD Feather #3

merged 2 commits into from
Apr 11, 2023

Conversation

BlitzCityDIY
Copy link

Adding EPD Feather support. PR that @ladyada has been testing

@BlitzCityDIY BlitzCityDIY requested a review from caternuson April 11, 2023 14:43
@caternuson
Copy link

I don't have hardware to test. Generally looks OK, with the nominal fixes for SPI0/SPI1 that @ladyada discovered when testing with actual hardware.

@ladyada
Copy link
Member

ladyada commented Apr 11, 2023

i tested this UF2 as long as its the one with the crystal-startup-delay thingy!

@BlitzCityDIY
Copy link
Author

yes, i did add that to my local install of the pico sdk that is pinned. @caternuson that's where that is defined right?

@caternuson
Copy link

The "crystal-startup-delay thingy" would be this:

Local copy of pico-sdk had changes to pico-sdk/src/rp2_common/hardware_xosc/xosc.c:

    xosc_hw->startup = startup_delay * 64;

from here:
#1

In this repo's current state, this is still a required manual step. That is due to the commit point referenced by the pico-sdk submodule (pico-sdk @ fc10a97). It pre-dates this PR:
raspberrypi/pico-sdk#457
which adds a way to configure this without modifying SDK source code. That PR thread also mentions the reason for needing this extra delay.

Suggest making a new issue/PR to address updating the pico-sdk submodule and dealing with startup delay.

@caternuson caternuson merged commit 5a80729 into adafruit:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants