change deprecated String type to AbstractString as per 0.4 spec #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,7 +78,7 @@ false | |||
| 1 < 2 < 3 # => true | |||
| 2 < 3 < 2 # => false | |||
|
|
|||
| # Strings are created with " | |||
| # AbstractStrings are created with " | |||
There was a problem hiding this comment.
uhm, care to explain a bit though? It's very surprising
There was a problem hiding this comment.
Here's the link to the rationale
There was a problem hiding this comment.
I'm a bit -1 on this line itself being changed, because it's so confusing. If you want to keep this one change, care to add a "(Julia's basic string type" note or something?
There was a problem hiding this comment.
Yeah, you're right, that is confusing as a first sighting for string in julia. I'll clarify it.
There was a problem hiding this comment.
Made a few changes, thoughts?
|
Looks good to me. Thanks for putting up with my nitpicks ;-). |
vendethiel
added a commit
that referenced
this pull request
Oct 10, 2015
change deprecated String type to AbstractString as per 0.4 spec
|
🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.