Refs #25736 - keep mdc after the middleware #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
reviewed
Jan 24, 2019
iNecas
force-pushed
the
keep-current-mdc
branch
from
c08ace9 to
4a56bfa
Compare
And rely on Dynlfow's `run_user_code` to clean it once not needed.
iNecas
force-pushed
the
keep-current-mdc
branch
from
4a56bfa to
690146b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And rely on Dynlfow's
run_user_codeto clean it once not needed.I've noticed that exceptions logged by dynflow didin't have the request id, because there are logged
outside of the middleware stack. Seems like keeping it until the use code runs is the simplest solution
to cover most of the cases.
Corresponding dynflow changes are here Dynflow/dynflow#315