Fixes #25736 - Pass id of request which triggered a task into the task #383
Conversation
adamruzicka
force-pushed
the
keep-current-mdc
branch
from
a17240b to
07d99f7
Compare
adamruzicka
force-pushed
the
keep-current-mdc
branch
from
07d99f7 to
3280cf1
Compare
|
Tested and works well, except covering exceptions logging, which could be solved by this adamruzicka#2 |
|
Dynflow 1.2.1 has been released, let's bump the version dependency |
app/lib/actions/recurring_action.rb
Outdated
| @@ -10,11 +10,15 @@ def self.included(base) | |||
| # Hook to be called when a repetition needs to be triggered. This either happens when the plan goes into planned state | |||
| # or when it fails. | |||
| def trigger_repeat(execution_plan) | |||
| request_id = ::Logging.mdc['request'] | |||
| ::Logging.mdc['request'] = nil | |||
There was a problem hiding this comment.
After discussion with @ponrjek, we think the best way to support the recurring jobs would be to assign it a new (but non-empty) request id, so that we can group the related tasks from every iteration together (otherwise, we can do it just with the first iteration)
There was a problem hiding this comment.
Should I also log that?
There was a problem hiding this comment.
I canl handle the logging part in separate PR
|
Two last comments before merging this. |
And rely on Dynlfow's `run_user_code` to clean it once not needed.
adamruzicka
force-pushed
the
keep-current-mdc
branch
from
1948f6d to
47f6094
Compare
| # Perform the planning (trigger repeat) | ||
| task.execution_plan.delay_record.plan | ||
| repetition = recurring_logic.tasks.find { |t| t.id != task.id } | ||
| repetition.input[:current_request_id].must_be :nil? |
There was a problem hiding this comment.
This needs to be updated as well
|
Merged as 12b53f2, thanks @adamruzicka |
No description provided.