Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update torch examples dependency versions #1981

Merged
merged 6 commits into from
Jun 30, 2023
Merged

Update torch examples dependency versions #1981

merged 6 commits into from
Jun 30, 2023

Conversation

danielnugraha
Copy link
Contributor

@danielnugraha danielnugraha commented Jun 30, 2023 •
edited
Loading

Issue

Description

There are some inconsistencies with the examples that uses pytorch as its dependencies, resulting in error when poetry tries to resolve the dependencies. One example is the torchvision dependency requires newer torch version then the specified version in pyproject.toml file.

Related issues/PRs

Helps to fix #1980.

Proposal

Explanation

Following changes in pyproject.toml and requirements.txt are made to the examples that uses pytorch as its dependencies:

  1. Fix torch version to 1.12.0 and torchvision to 0.13.0
  2. Opacus' and embedded device's pytorch version are not changed.
  3. Fix python version to >=3.8, <3.11.
  4. ^ on other dependencies are removed.
  5. Flwr local dependency path is changed to the latest flwr-nightly version.
  6. Flwr version is fixed to >=1.0, <2.0.

Checklist

  • Implement proposed change
  • Make CI checks pass

Any other comments?

This was referenced Jun 30, 2023
Merged
Merged
Draft
@danielnugraha danielnugraha changed the title Update torch examples Update torch examples dependency versions Jun 30, 2023
@tanertopal tanertopal enabled auto-merge (squash) June 30, 2023 12:52
@tanertopal tanertopal merged commit 0df5b13 into main Jun 30, 2023
@tanertopal tanertopal deleted the update-torch-examples branch June 30, 2023 12:58
tanertopal added a commit that referenced this pull request Jul 5, 2023
@tanertopal
Merge branch 'main' into improve_ci_speed
afe26c3 
* main:
  Remove line with typo from script (#2001)
  Fix simulation error caused by Pydantic version in Ray (#2002)
  Update mxnet examples dependency versions (#1982)
  Update torch version in pyproject.toml files (#1993)
  Update tensorflow examples dependency versions (#1984)
  Fix the baseline template docstrings (#1983)
  Fix Baselines CI PyLint error by using Resampling (#1998)
  Make tensorflow optional when using tensorboard (#1879)
  Update dependencies for MXNet example (#1988)
  Fix `starlette` vulnerability (#1992)
  Fix vulnerability detected by Dependabot (#1990)
  Fix dependabot critical errors (#1989)
  Add Ruff UP check (#1946)
  Update torch examples dependency versions (#1981)
  Remove && from the end of lines in test.sh (#1979)
  Baselines docs updates (#1977)
  Fixes GitHub CI issue because of behaviour change (#1976)
@danielnugraha danielnugraha mentioned this pull request Jul 7, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielnugraha @tanertopal