Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove line with typo from script #2001

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Remove line with typo from script #2001

merged 2 commits into from
Jul 5, 2023

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Jul 4, 2023

Issue

Description

A weird line is present on the setup-defaults.sh which serve no purpose and makes the program crash, it seems to have been added by error.

Related issues/PRs

N/A

Proposal

Explanation

Remove the problematic line from dev/setup-defaults.sh and baselines/dev/setup-defaults.sh.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@charlesbvll charlesbvll marked this pull request as ready for review July 4, 2023 19:05
@tanertopal tanertopal added this pull request to the merge queue Jul 5, 2023
@tanertopal tanertopal removed this pull request from the merge queue due to the queue being cleared Jul 5, 2023
@tanertopal tanertopal enabled auto-merge (squash) July 5, 2023 07:35
@tanertopal tanertopal merged commit afbdad4 into main Jul 5, 2023
@tanertopal tanertopal deleted the fix-install-scripts branch July 5, 2023 07:40
tanertopal added a commit that referenced this pull request Jul 5, 2023
* main:
  Remove line with typo from script (#2001)
  Fix simulation error caused by Pydantic version in Ray (#2002)
  Update mxnet examples dependency versions (#1982)
  Update torch version in pyproject.toml files (#1993)
  Update tensorflow examples dependency versions (#1984)
  Fix the baseline template docstrings (#1983)
  Fix Baselines CI PyLint error by using Resampling (#1998)
  Make tensorflow optional when using tensorboard (#1879)
  Update dependencies for MXNet example (#1988)
  Fix `starlette` vulnerability (#1992)
  Fix vulnerability detected by Dependabot (#1990)
  Fix dependabot critical errors (#1989)
  Add Ruff UP check (#1946)
  Update torch examples dependency versions (#1981)
  Remove && from the end of lines in test.sh (#1979)
  Baselines docs updates (#1977)
  Fixes GitHub CI issue because of behaviour change (#1976)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants