Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage-apps): update ceph-csi to 3.8.0 #985

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

tongpu
Copy link
Member

@tongpu tongpu commented Mar 1, 2023

Description

Update ceph-csi in storage-apps to 3.8.0

This release provides the following new features:

A potential issue for one of our customers, which is still running Octopus could be that ceph-csi is following the upstream support for Ceph releases and because of that they officially removed support for Octopus in this release of ceph-csi. As this is the only customer were we're using ceph-csi we could also potentially remove it from storage-apps?

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 1, 2023
@tongpu tongpu marked this pull request as ready for review March 1, 2023 17:07
@tongpu tongpu requested a review from a team as a code owner March 1, 2023 17:07
@tongpu tongpu requested review from eyenx and luk43 March 1, 2023 17:07
@eyenx
Copy link
Member

eyenx commented Mar 9, 2023

wanna merge this @tongpu

@tongpu
Copy link
Member Author

tongpu commented Mar 10, 2023

I'm honestly not convinced if I want to merge this. We're only using it in a single place and there it could lead to conflicts. I guess I'd rather remove it from here and managed it outside of storage-apps for that customer.

@hairmare
Copy link
Contributor

We're only using it in a single place and there it could lead to conflicts.

can you elaborate how a simple version bump could lead to conflicts? it's not like storage-apps provides more than a simple version pin.

@tongpu
Copy link
Member Author

tongpu commented Mar 13, 2023

We're only using it in a single place and there it could lead to conflicts.

can you elaborate how a simple version bump could lead to conflicts? it's not like storage-apps provides more than a simple version pin.

The version that I'm proposing for a pin here officially doesn't support the Ceph version that this customer is running and we're not running the ceph-csi integration anymore at any other customer, so I'm not sure if it wouldn't be the better choice to remove the chart from storage-apps.

@hairmare hairmare merged commit 718296d into adfinis:main Mar 13, 2023
@tongpu tongpu deleted the chore/update_ceph-csi branch March 13, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants