Allow users to upload notifications #120
Conversation
|
Can you provide details of what this PR is about and what problem it solves? |
Yes, Its only in draft right now because I was just testing it. I need to cleanup a lot of stuff (as you can see I modified the hooks executable for easier testing). The gist is that I want to be able to provide a custom notify clause in the monorepo-plugin config so that I can customize the github commit statuses https://buildkite.com/docs/integrations/github#customizing-commit-statuses. Right now the yaml marshalling doesn't support this key. |
plugin.go
Outdated
| @@ -8,7 +8,7 @@ import ( | |||
| log "github.com/sirupsen/logrus" | |||
| ) | |||
|
|
|||
| const pluginName = "github.com/monebag/monorepo-diff" | |||
| const pluginName = "monorepo-diff-buildkite-plugin" | |||
There was a problem hiding this comment.
I am happy to revert this change along with the strings.Contains below, but this seemed to be more flexible to me. Let me know what you think.
There was a problem hiding this comment.
I prefer to leave it as it is. Once you revert it back I will merge the PR
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 80.55% 83.68% +3.13%
==========================================
Files 4 4
Lines 180 331 +151
==========================================
+ Hits 145 277 +132
- Misses 23 42 +19
Partials 12 12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
plugin.go
Outdated
| @@ -53,6 +53,7 @@ type Step struct { | |||
| Env map[string]string `yaml:"env,omitempty"` | |||
| Async bool `yaml:"async,omitempty"` | |||
| SoftFail interface{} `json:"soft_fail" yaml:"soft_fail,omitempty"` | |||
| Notify interface{} `yaml:"notify,omitempty"` | |||
There was a problem hiding this comment.
Is it possible to add proper type with possible values? Will serve as a documentation and also validation.
adikari
force-pushed
the
jonathan/upload-notify
branch
from
2e91bd2 to
245c747
Compare
This PR adds support for the per-step
notifykey that buildkite accepts.https://buildkite.com/docs/pipelines/notifications