Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add douban and zhihu icon #1084

Merged
merged 2 commits into from
Feb 4, 2023
Merged

add douban and zhihu icon #1084

merged 2 commits into from
Feb 4, 2023

Conversation

alswl
Copy link
Contributor

@alswl alswl commented Nov 6, 2022 •
edited

What does this PR change? What problem does it solve?

Add douban and zhihu icon fron http://www.iconfont.cn/ .
These sites are well-known social web sites in China.

douban is 豆
zhihu is 知

image

Was the change discussed in an issue or in the Discussions before?

No icon for douban and zhihu.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@sonarcloud
Copy link

sonarcloud bot commented Nov 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alswl
Copy link
Contributor Author

alswl commented Nov 24, 2022

@adityatelange Friendly ping.

@jinmiaoluo
Copy link

jinmiaoluo commented Jan 30, 2023 •
edited

Douban is similar to Goodreads.
Zhihu is similar to Quora.
Both are very common social networks in China.
Hope this PR can be merged.

@jinmiaoluo
Copy link

jinmiaoluo commented Jan 30, 2023 •
edited

@alswl Your commit message has typo, douban, not douabn.

@alswl alswl changed the title add douabn and zhihu icon add douab and zhihu icon Jan 30, 2023
@alswl alswl changed the title add douab and zhihu icon add douban and zhihu icon Jan 30, 2023
adityatelange
adityatelange requested changes Feb 4, 2023
View reviewed changes
Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the svgs in alphabetical order by their name

@sonarcloud
Copy link

sonarcloud bot commented Feb 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alswl
Copy link
Contributor Author

alswl commented Feb 4, 2023

Please add the svgs in alphabetical order by their name

It was fixed, thanks for your response.

@adityatelange adityatelange merged commit a35a33c into adityatelange:master Feb 4, 2023
@adityatelange adityatelange added the icons Related to Icons label Feb 4, 2023
Nicceboy added a commit to Nicceboy/hugo-PaperMod that referenced this pull request Feb 11, 2023
@Nicceboy @adityatelange
@eisraeli @niturk @EssaAlshammri @igorr0driguez @fobo66 @MacKarp @Merovius @theJoshMuller @raisilhamn @Natooz @JingBh @k-yone @alswl
Update from origin (#1)
85e5774 
* Fix multi-line anchor tags not highlighted/underlined.

fixes: adityatelange#1107

* Update Hebrew translation (adityatelange#1104)

Signed-off-by: Eran Israeli <eisraeli@redhat.com>

* Improve Turkish Translation tr.yaml (adityatelange#1098)

* update arabic pagination translation (adityatelange#1137)

* PT translation updated (adityatelange#1124)

Signed-off-by: igorr0driguez <42983358+igorr0driguez@users.noreply.github.com>

* Added Belarusian translations i18n/be.yaml (adityatelange#1144)

* updated Polish translation (adityatelange#1148)

* Add Tumblr Icon (adityatelange#1115)

* Add TryHackMe Icon (adityatelange#1113)

from Simple Icons https://github.com/simple-icons/simple-icons/blob/develop/icons/tryhackme.svg

* Add codeforces icon (adityatelange#1092)

From https://github.com/simple-icons/simple-icons

* Google scholar svg icon fixed, now unfilled curved line (adityatelange#1064)

* Add netease cloud music icon (adityatelange#1093)

* Add title to the image tag in rss.xml (adityatelange#1105)

Ref: https://cyber.harvard.edu/rss/rss.html#ltimagegtSubelementOfLtchannelgt

* Add douban and zhihu icon (adityatelange#1084)

* Update README

---------

Signed-off-by: Eran Israeli <eisraeli@redhat.com>
Signed-off-by: igorr0driguez <42983358+igorr0driguez@users.noreply.github.com>
Co-authored-by: Aditya Telange <21258296+adityatelange@users.noreply.github.com>
Co-authored-by: Eran Israeli <eisraeli@redhat.com>
Co-authored-by: Nikita <3787035+niturk@users.noreply.github.com>
Co-authored-by: Essa Alshammri <essa.alshammri@gmail.com>
Co-authored-by: Igor Rodriguez <42983358+igorr0driguez@users.noreply.github.com>
Co-authored-by: Andrey Mukamolov <4471821+fobo66@users.noreply.github.com>
Co-authored-by: Karpfly <karpfly@gmail.com>
Co-authored-by: Axel Wagner <mail@merovius.de>
Co-authored-by: Josh Müller <39825267+theJoshMuller@users.noreply.github.com>
Co-authored-by: rais ilham <rais.ilham.nustara-2020@fst.unair.ac.id>
Co-authored-by: Nathan Fradet <56734983+Natooz@users.noreply.github.com>
Co-authored-by: Bohao Jing <jingbohao@yeah.net>
Co-authored-by: k-yone <9046344+k-yone@users.noreply.github.com>
Co-authored-by: Jingchao <alswlx@gmail.com>
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
@alswl
Add douban and zhihu icon (adityatelange#1084)
f54fb6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityatelange adityatelange adityatelange approved these changes

Assignees
No one assigned
Labels
icons Related to Icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alswl @jinmiaoluo @adityatelange