-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add title to the image tag in rss.xml #1105
add title to the image tag in rss.xml #1105
Conversation
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the title described here https://cyber.harvard.edu/rss/rss.html#ltimagegtSubelementOfLtchannelgt
says:
<title> describes the image, it's used in the ALT attribute of the HTMLtag when the channel is rendered in HTML.
Is not the site's title
Thing is we couldn't get the image's alt text which is inside the markdown with the |
I see. You're right. The document says this |
By the way, this |
Nope, the link is for each image provided by user. |
@k-yone I was wrong. It is used to describe the whole website. We can merge. |
For RSS feeds present inside a section we'll have to add something, but that is a different topic to be discussed. |
* Fix multi-line anchor tags not highlighted/underlined. fixes: adityatelange#1107 * Update Hebrew translation (adityatelange#1104) Signed-off-by: Eran Israeli <eisraeli@redhat.com> * Improve Turkish Translation tr.yaml (adityatelange#1098) * update arabic pagination translation (adityatelange#1137) * PT translation updated (adityatelange#1124) Signed-off-by: igorr0driguez <42983358+igorr0driguez@users.noreply.github.com> * Added Belarusian translations i18n/be.yaml (adityatelange#1144) * updated Polish translation (adityatelange#1148) * Add Tumblr Icon (adityatelange#1115) * Add TryHackMe Icon (adityatelange#1113) from Simple Icons https://github.com/simple-icons/simple-icons/blob/develop/icons/tryhackme.svg * Add codeforces icon (adityatelange#1092) From https://github.com/simple-icons/simple-icons * Google scholar svg icon fixed, now unfilled curved line (adityatelange#1064) * Add netease cloud music icon (adityatelange#1093) * Add title to the image tag in rss.xml (adityatelange#1105) Ref: https://cyber.harvard.edu/rss/rss.html#ltimagegtSubelementOfLtchannelgt * Add douban and zhihu icon (adityatelange#1084) * Update README --------- Signed-off-by: Eran Israeli <eisraeli@redhat.com> Signed-off-by: igorr0driguez <42983358+igorr0driguez@users.noreply.github.com> Co-authored-by: Aditya Telange <21258296+adityatelange@users.noreply.github.com> Co-authored-by: Eran Israeli <eisraeli@redhat.com> Co-authored-by: Nikita <3787035+niturk@users.noreply.github.com> Co-authored-by: Essa Alshammri <essa.alshammri@gmail.com> Co-authored-by: Igor Rodriguez <42983358+igorr0driguez@users.noreply.github.com> Co-authored-by: Andrey Mukamolov <4471821+fobo66@users.noreply.github.com> Co-authored-by: Karpfly <karpfly@gmail.com> Co-authored-by: Axel Wagner <mail@merovius.de> Co-authored-by: Josh Müller <39825267+theJoshMuller@users.noreply.github.com> Co-authored-by: rais ilham <rais.ilham.nustara-2020@fst.unair.ac.id> Co-authored-by: Nathan Fradet <56734983+Natooz@users.noreply.github.com> Co-authored-by: Bohao Jing <jingbohao@yeah.net> Co-authored-by: k-yone <9046344+k-yone@users.noreply.github.com> Co-authored-by: Jingchao <alswlx@gmail.com>
What does this PR change? What problem does it solve?
<title>
tag is missing in the<image>
tag in rss.xmlWas the change discussed in an issue or in the Discussions before?
PR Checklist