[makeotfexe] Remove major version number warning

Fixes #610
adobe-type-tools · Sep 21, 2018 · b1d76f9 · b1d76f9
1 parent b3e5c8f
commit b1d76f9
Show file tree

Hide file tree

Showing 4 changed files with 85 additions and 4 deletions.
diff --git a/c/makeotf/makeotf_lib/source/hotconv/feat.c b/c/makeotf/makeotf_lib/source/hotconv/feat.c
@@ -3936,10 +3936,6 @@ static void setFontRev(char *rev) {
 
     long major = strtol(rev, &fraction, 10);
 
-    if (major < 1 || major > 255) {
-        featMsg(hotWARNING, "Major version number not in range 1 .. 255");
-    }
-
     if ((fraction != 0) && (strlen(fraction) > 0)) {
         short strLen = strlen(fraction);
         minor = strtod(fraction, NULL);

diff --git a/tests/makeotfexe_data/input/bug610/font.pfa b/tests/makeotfexe_data/input/bug610/font.pfa
diff --git a/tests/makeotfexe_data/input/bug610/v0005.fea b/tests/makeotfexe_data/input/bug610/v0005.fea
@@ -0,0 +1,3 @@
+table head {
+	FontRevision 0.005;
+} head;
diff --git a/tests/makeotfexe_test.py b/tests/makeotfexe_test.py
@@ -124,3 +124,20 @@ def test_DFLT_script_with_any_lang_bug438():
                    '    <created value=' + SPLIT_MARKER +
                    '    <modified value=',
                    '-r', r'^\s+Version.*;hotconv.*;makeotfexe'])
+
+
+def test_version_warning_bug610():
+    input_filename = 'bug610/font.pfa'
+    feat_filename = 'bug610/v0005.fea'
+    otf_path = _get_temp_file_path()
+
+    stderr_path = runner(
+        CMD + ['-s', '-e', '-o',
+               'f', '_{}'.format(_get_input_path(input_filename)),
+               'ff', '_{}'.format(_get_input_path(feat_filename)),
+               'o', '_{}'.format(otf_path)])
+
+    with open(stderr_path, 'rb') as f:
+        output = f.read()
+    assert (b"[WARNING] <SourceSans-Test> Major version number not in "
+            b"range 1 .. 255") not in output