Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeotfexe] Setting head.FontRevision to some value like 0.005 will throw a warning #610

Closed
LIXiangChen opened this issue Sep 13, 2018 · 4 comments

Comments

@LIXiangChen
Copy link

Major version number not in range 1 .. 255

Why does major version number have to >= 1?

@LIXiangChen LIXiangChen changed the title [makeotf] Setting head.FontRevision to something like 0.005 will throw a warning [makeotf] Setting head.FontRevision to some value like 0.005 will throw a warning Sep 13, 2018
@miguelsousa
Copy link
Member

You can use a version number lower than 1.000, but if you do that the OTF will not work (or even install, IIRC) on Windows. This is something that was done in the early days of OpenType support, to block the usage of the first set of experimental fonts. I believe this is documented somewhere in the spec.

@kenlunde
Copy link

@miguelsousa To clarify, OTFs with a head.fontRevision value less than 1.000 cannot be installed on Windows only if the OS/2.achVendID value is set to ADBE.

@miguelsousa
Copy link
Member

@kenlunde thanks for the clarification.
@LIXiangChen I'll see if there's a simple way to hide that warning from most font developers.

@miguelsousa miguelsousa reopened this Sep 13, 2018
@miguelsousa miguelsousa self-assigned this Sep 18, 2018
@miguelsousa
Copy link
Member

The warning actually comes from makeotfexe. I'm going to remove the check from there and implement it in makeotf.

@miguelsousa miguelsousa changed the title [makeotf] Setting head.FontRevision to some value like 0.005 will throw a warning [makeotfexe] Setting head.FontRevision to some value like 0.005 will throw a warning Sep 20, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants