[makeinstancesufo] wrong camelCasing in designspace attribute

[frankrolf]

If an instance entry in a designspace file does not contain a PostScript font name attribute, makeinstancesufo complains in the following way:

WARNING:afdko.makeinstancesufo:Instance at index 0 has no 'postScriptFontName' attribute.

However, the ps font name needs to be indicated like this:

postscriptfontname="BlahBlah-Blah"

Note the casing being different in warning vs required.

[frankrolf]

This change seems to have fallen on our feet (not sure how):
Generating from a normal .designspace, I get this output:

WARNING:afdko.makeinstancesufo:Instance at index 0 has no 'familyname' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 0 has no 'postscriptfontname' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 0 has no 'stylename' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 1 has no 'familyname' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 1 has no 'postscriptfontname' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 1 has no 'stylename' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 2 has no 'familyname' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 2 has no 'postscriptfontname' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 2 has no 'stylename' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 3 has no 'familyname' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 3 has no 'postscriptfontname' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 3 has no 'stylename' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 4 has no 'familyname' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 4 has no 'postscriptfontname' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 4 has no 'stylename' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 5 has no 'familyname' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 5 has no 'postscriptfontname' attribute.
WARNING:afdko.makeinstancesufo:Instance at index 5 has no 'stylename' attribute.

All of those attributes exist.
Will investigate.

[josh-hadley]

I had a look at this and it looks like the designspaceLib code reads the XML attribute as all lowercase (e.g. postscriptfontname), but uses camel-cased for the Python attribute (postScriptFontName), which is a bit confusing.

The fix here is to revert the checks in makeinstancesufo back to camel-cased (which is testing the Python attribute names, not XML), but keep the all-lowercase attribute names in the .designspace files.

[frankrolf]

Alright, thank you Josh! Perhaps the real solution to the problem I pointed out should be in this line:

from

                    f"Instance at index {i} has no '{attr_name}' attribute.")

to

                    f"Instance at index {i} has no '{attr_name.lower()}' attribute.")

Then there would not be any messing with the attribute names, and the indication would correspond to the attribute flags as required in the .designspace file.

[josh-hadley]

Having the error message use the XML (all-lowercase) attribute name seems sensible for communicating the problem to the user (in addition to reverting the actual check to use the Python/camel-cased names).