Make designspace attributes lowercase. #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corresponding to the specification here: https://github.com/fonttools/fonttools/tree/master/Doc/source/designspaceLib\#attributes-9 The spec itself seems to be inconsistent in attribute casing.
punchcutter
approved these changes
Aug 20, 2020
|
Travis CI has been failing to get results back to GitHub, so I'm going to override that particular required status. |
1div0
pushed a commit
to 1div0/afdko
that referenced
this pull request
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make designspace attributes all lowercase, corresponding to the specification here: https://github.com/fonttools/fonttools/tree/master/Doc/source/designspaceLib\#attributes-9
The spec itself seems to be inconsistent in attribute casing.
Tested with a
<designspace format="3">file.Resolves #1211 .