Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeotfexe] FEA token reported in syntax error is off-by-one #492

Closed
miguelsousa opened this issue Jul 18, 2018 · 0 comments
Closed

[makeotfexe] FEA token reported in syntax error is off-by-one #492

miguelsousa opened this issue Jul 18, 2018 · 0 comments
Assignees

Comments

@miguelsousa
Copy link
Member

miguelsousa commented Jul 18, 2018

When reporting a FEA syntax error triggered by finding a glyph name that is included in a glyph class but not present in the font, makeotfexe references the next token instead of the name of the missing glyph.

  • If the missing glyph is the last in the class, the syntax error will reference ] (a bracket).
  • If the missing glyph is NOT the last in the class, the syntax error will reference the name of the glyph that comes after the name of the missing glyph.

Test case:

makeotfexe -f t1pfa.pfa -ff features.fea

Result:

syntax error at "a" [features.fea 2]

Expected result:

syntax error at "glyph_not_found" [features.fea 2]

bug492.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants