Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[makeotfexe] Correct "glyph not in font" error #698

Merged
merged 2 commits into from
Dec 18, 2018
Merged

[makeotfexe] Correct "glyph not in font" error #698

merged 2 commits into from
Dec 18, 2018

Conversation

miguelsousa
Copy link
Member

Fixes #492

@miguelsousa
Copy link
Member Author

Thanks @cjchapman. I'll wait for @readroberts review before merging.

readroberts
readroberts approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@readroberts readroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@miguelsousa miguelsousa merged commit 06588d5 into develop Dec 18, 2018
@miguelsousa miguelsousa deleted the makeotfexe-bug492 branch December 18, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@readroberts readroberts readroberts approved these changes

@cjchapman cjchapman cjchapman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelsousa @readroberts @cjchapman