Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fdselect4.otf contains invalid CFF2 Private Dict operator #897

Closed
khaledhosny opened this issue Aug 9, 2019 · 0 comments · Fixed by #906
Closed

fdselect4.otf contains invalid CFF2 Private Dict operator #897

khaledhosny opened this issue Aug 9, 2019 · 0 comments · Fixed by #906
Assignees
@cjchapman
Labels
c-tools

Comments

@khaledhosny
Copy link
Collaborator

khaledhosny commented Aug 9, 2019 •
edited by cjchapman
Loading

The font tests/tx_data/input/fdselect4.otf has defaultWidthX operators in its Private Dictionary(s). FontTools will ignore the operator (turning it into a comment), but OTS will reject such font.

Since this is a test font, it might be OK to leave it like it is, though.
khaledhosny added a commit to khaledhosny/ots that referenced this issue Aug 9, 2019
@khaledhosny
[CFF2] Add some broken fonts
309b417 
adobe-type-tools/afdko#895
adobe-type-tools/afdko#896
adobe-type-tools/afdko#897
@cjchapman cjchapman self-assigned this Aug 12, 2019
cjchapman added a commit that referenced this issue Aug 15, 2019
@cjchapman
fix for issue 897
e9267aa 
fixes #897
The original `fdselect4.otf` font had `defaultWidthX` operators in the private dictionaries of a CFF2 table, which is incorrect. I copied that font to `tests/tx_data/input/bad/bug897.otf` for test purposes, and removed the `defaultWidthX` operators from the private dictionaries of `fdselect4.otf`. I then added tests to check that `tx -cff2` removes the `defaultWidthX` operators from the private dictionaries of its CFF2 output and `tx -cff` preserves them in its CFF output.
@cjchapman cjchapman mentioned this issue Aug 15, 2019
Merged
miguelsousa pushed a commit that referenced this issue Aug 15, 2019
@cjchapman @miguelsousa
fix for issue 897
2ae050d 
fixes #897
The original `fdselect4.otf` font had `defaultWidthX` operators in the private dictionaries of a CFF2 table, which is incorrect. I copied that font to `tests/tx_data/input/bad/bug897.otf` for test purposes, and removed the `defaultWidthX` operators from the private dictionaries of `fdselect4.otf`. I then added tests to check that `tx -cff2` removes the `defaultWidthX` operators from the private dictionaries of its CFF2 output and `tx -cff` preserves them in its CFF output.
khaledhosny added a commit to khaledhosny/ots that referenced this issue Aug 15, 2019
@khaledhosny
[CFF2] Add some broken fonts
81c702c 
adobe-type-tools/afdko#895
adobe-type-tools/afdko#896
adobe-type-tools/afdko#897
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjchapman cjchapman

Labels
c-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix for issue 897 adobe-type-tools/afdko
2 participants
@khaledhosny @cjchapman