fix for issue 897 #906
Merged
fix for issue 897 #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #897 The original `fdselect4.otf` font had `defaultWidthX` operators in the private dictionaries of a CFF2 table, which is incorrect. I copied that font to `tests/tx_data/input/bad/bug897.otf` for test purposes, and removed the `defaultWidthX` operators from the private dictionaries of `fdselect4.otf`. I then added tests to check that `tx -cff2` removes the `defaultWidthX` operators from the private dictionaries of its CFF2 output and `tx -cff` preserves them in its CFF output.
miguelsousa
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #897
The original
fdselect4.otffont haddefaultWidthXoperators in the private dictionaries of a CFF2 table, which is incorrect. I copied that font totests/tx_data/input/bad/bug897.otffor test purposes, and removed thedefaultWidthXoperators from the private dictionaries offdselect4.otf. I then added tests to check thattx -cff2removes thedefaultWidthXoperators from the private dictionaries of its CFF2 output andtx -cffpreserves them in its CFF output.