Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tx] Replace UFO fontinfo.plist parsing with libxml2 #1515

Merged
merged 9 commits into from
Jun 15, 2022

Conversation

kaydeearts
Copy link
Collaborator

This is the cleaned up version of #1510
This is part of a larger project to replace current xml parsing code in tx with the libxml2 library.

This PR replaces fontinfo.plist parsing code with libxml2, as well as sets up the AFDKO for cross-platform compatibility with libxml2 (see CMake changes)

This should also resolve issue #1467 , for which a test has been added in tx_test.py

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link
Collaborator

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting aside the yet-to-be-uncommented warning messages, this all looks good to me.

@skef skef removed the request for review from iterumllc June 15, 2022 07:02
Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, congrats on getting this all working!

@benkiel
Copy link
Contributor

benkiel commented Jun 15, 2022

YAY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants