Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tx] Replace UFO lib.plist parsing with libxml2 #1523

Merged
merged 11 commits into from
Jun 24, 2022
Merged

Conversation

kaydeearts
Copy link
Collaborator

@kaydeearts kaydeearts commented Jun 23, 2022

Description

This PR replaces lib.plist parsing code with libxml2 #1520 . (part of the tx parser replacement with libxml2 project), and is related to #1515

This should also fix #1306 , #1130 , #1305 , which discuss that tx/makeotf should not fail when missing lib.plist.
A missing lib.plist should now emit a warning to the user instead of failing. These warnings have been improved and tests have been added to both tx_test.py and makeotf_test.py.
The only exception to this is for cidkeyed UFOs that have cid identifiers defined within the glyphs files, for which there was a failure message already existing. This test case has also been added.

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2022

This pull request introduces 1 alert when merging b1e4b28 into b02b850 - view on LGTM.com

new alerts:

  • 1 for Wrong type of arguments to formatting function

@kaydeearts kaydeearts linked an issue Jun 23, 2022 that may be closed by this pull request
skef
skef previously approved these changes Jun 23, 2022
Copy link
Collaborator

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

josh-hadley
josh-hadley previously approved these changes Jun 23, 2022
Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kaydeearts kaydeearts dismissed stale reviews from josh-hadley and skef via 0223f87 June 24, 2022 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants