-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tx] Replace UFO lib.plist parsing with libxml2 #1523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rify other test as edge case
…yphs, replace with one warning
This pull request introduces 1 alert when merging b1e4b28 into b02b850 - view on LGTM.com new alerts:
|
skef
previously approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
josh-hadley
previously approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
kaydeearts
force-pushed
the
kd-libxml2-lib
branch
from
June 24, 2022 22:17
0509a08
to
8ab7d1c
Compare
This was referenced Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces lib.plist parsing code with libxml2 #1520 . (part of the tx parser replacement with libxml2 project), and is related to #1515
This should also fix #1306 , #1130 , #1305 , which discuss that
tx
/makeotf
should not fail when missing lib.plist.A missing lib.plist should now emit a warning to the user instead of failing. These warnings have been improved and tests have been added to both
tx_test.py
andmakeotf_test.py
.The only exception to this is for cidkeyed UFOs that have cid identifiers defined within the glyphs files, for which there was a failure message already existing. This test case has also been added.
Checklist: