fix for #345 [tx] -cff2 fails to convert CID/CFF1 to multi-FD CFF2 #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CFF font Initialize info.cid for each glyph in CID/CFF2 font with its gid, otherwise when converting CFF2 to CFF1, cfwAddGlyph regards all glyphs as CID = 0, optimize away all font dicts except font dict 0 for CID 0.
…s/afdko into blueshade-update
Also removed "l" from printf formatting strings for 32-bit integers
…s/afdko into blueshade-update
also fixed header search path in XCode project setting
…s/afdko into blueshade-update
this also fixes linux build of spot
Fixed the following bugs in cffwritre & cffwrite_t2cstr when converting CFF1 to CFF2: 1. VarStore offset should be set to 0 for non-VF 2. Don't attempt to copy zero-length CFF2 charstring which may legally happen (otherwise may trigger an assert in fillbuf) 3. If non-VF (numRegions = 0), don't attempt to output blend values
…s/afdko into blueshade-update
miguelsousa
approved these changes
May 2, 2018
This was referenced May 2, 2018
schriftgestalt
pushed a commit
to schriftgestalt/afdko
that referenced
this pull request
May 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually the problem was not CID/CFF1 specific, could happen when converting non-CID/CFF1 to CFF2.
Fixed the following bugs in cffwritre & cffwrite_t2cstr when converting CFF1 to CFF2: