feat: migration to rum v2 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidnuescheler and I came to the conclusion we do not need a custom event, at least for now. The only consumer would be our boilerplate, for which we know exactly when to call |
adobe-bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
# [2.5.0](v2.4.0...v2.5.0) (2024-07-16) ### Features * migration to rum v2 ([#76](#76)) ([7ebf186](7ebf186))
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use rum v2 and optimise rum loading sequence using manual enhance method - depends on adobe/helix-rum-js#175
This introduces a new custom event:
hlx:section:loadedwhich fires when a section is loaded.When first section is loaded, we "enhance" the rum sampling.