feat: improving enhancer loading timing #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger no release when merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 66 69 +3
=========================================
+ Hits 66 69 +3 ☔ View full report in Codecov by Sentry. |
trieloff
approved these changes
Jun 21, 2024
adobe-bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
# [2.2.0](v2.1.4...v2.2.0) (2024-08-13) ### Bug Fixes * **404:** send referrer ([84a6556](84a6556)) * release process ([#191](#191)) ([f40a949](f40a949)) ### Features * **bundle:** release a standalone 404.js that can be used to track error pages ([33d70b5](33d70b5)) * improve errors capture ([#189](#189)) ([d7448eb](d7448eb)) * improving enhancer loading timing ([#175](#175)) ([d9c690e](d9c690e)) * trigger release ([7d8f4e0](7d8f4e0))
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
This seems to be messing with adobe/helix-rum-enhancer#256 need to understand why |
|
Faster loading of rum-enhancer in the default behavior means that the URL manipulation needed for the test is coming too late. Fixed in adobe/helix-rum-enhancer@bd2eae3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new capability: let the consumer define when to load the
enhancer. To do so:window.hlx.RUM_MANUAL_ENHANCE = true;sampleRUM();sampleRUM.enhance();