[PLATIR-35300] Add array replace token support #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev-v4.2.2 #988 +/- ##
==============================================
- Coverage 89.93% 89.83% -0.10%
==============================================
Files 133 133
Lines 8338 8347 +9
==============================================
Hits 7498 7498
- Misses 840 849 +9 |
praveek
reviewed
Jan 16, 2024
| @@ -177,15 +177,15 @@ enum UserDefaultMigratorConstants { | |||
| static let DATASTORE_NAME = "com.adobe.edge.identity" | |||
|
|
|||
| enum DataStoreKeys: String, CaseIterable { | |||
| case IDENTITY_PROPERTIES = "identity.properties" | |||
| case IDENTITY_PROPERTIES = "identity.properties" | |||
There was a problem hiding this comment.
Did we commit unformatted files earlier, or is there any change in Swift format version that we're using?
There was a problem hiding this comment.
I'm not too sure how this happened. I just ran swiftformat locally and committed.
praveek
reviewed
Jan 16, 2024
…ssing other values
praveek
reviewed
Jan 17, 2024
praveek
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#986 Adds array string token replacement support for the LaunchRulesEngine