-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLATIR-35300] Add array replace token support #988
Merged
cdhoffmann
merged 10 commits into
adobe:dev-v4.2.2
from
cdhoffmann:addArrayReplaceTokenSupport
Jan 18, 2024
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9b8a96a
add array support for rules engine replace token
cdhoffmann e62827c
add attach data array test
cdhoffmann aca2ae1
swiftformat and fix test rule description
cdhoffmann d2870cb
make attach data array test more robust
cdhoffmann 5891ee9
add comments
cdhoffmann a88606c
add support for nested arrays and nested values inside the arrays.
cdhoffmann b1c0596
swiftformat
cdhoffmann a67d9e3
remove null check / break as it was breaking and exiting early and mi…
cdhoffmann f8dadc6
add null to test json for attach data
cdhoffmann a469027
unwrap optional instead of force cast
cdhoffmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 101 additions & 0 deletions
101
AEPCore/Tests/TestResources/rules_testAttachDataArray.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
{ | ||
"version": 1, | ||
"rules": [ | ||
{ | ||
"condition": { | ||
"type": "group", | ||
"definition": { | ||
"logic": "and", | ||
"conditions": [ | ||
{ | ||
"type": "group", | ||
"definition": { | ||
"logic": "or", | ||
"conditions": [ | ||
{ | ||
"type": "group", | ||
"definition": { | ||
"logic": "and", | ||
"conditions": [ | ||
{ | ||
"type": "matcher", | ||
"definition": { | ||
"key": "~type", | ||
"matcher": "eq", | ||
"values": [ | ||
"com.adobe.eventType.lifecycle" | ||
] | ||
} | ||
}, | ||
{ | ||
"type": "matcher", | ||
"definition": { | ||
"key": "~source", | ||
"matcher": "eq", | ||
"values": [ | ||
"com.adobe.eventSource.responseContent" | ||
] | ||
} | ||
}, | ||
{ | ||
"type": "matcher", | ||
"definition": { | ||
"key": "lifecyclecontextdata.launchevent", | ||
"matcher": "ex", | ||
"values": [] | ||
} | ||
} | ||
] | ||
} | ||
} | ||
] | ||
} | ||
}, | ||
{ | ||
"type": "group", | ||
"definition": { | ||
"logic": "and", | ||
"conditions": [ | ||
{ | ||
"type": "matcher", | ||
"definition": { | ||
"key": "~state.com.adobe.module.lifecycle/lifecyclecontextdata.carriername", | ||
"matcher": "eq", | ||
"values": [ | ||
"AT&T" | ||
] | ||
} | ||
} | ||
] | ||
} | ||
} | ||
] | ||
} | ||
}, | ||
"consequences": [ | ||
{ | ||
"id": "RCa839e401f54a459a9049328f9b609a07", | ||
"type": "add", | ||
"detail": { | ||
"eventdata": { | ||
"attached_data_array": [ | ||
"{%~state.com.adobe.module.lifecycle/lifecyclecontextdata.carriername%}", | ||
"testStringTopLevel", | ||
{ | ||
"testDictKey": "testVal", | ||
"osversionNested": "{%~state.com.adobe.module.lifecycle/lifecyclecontextdata.osversion%}" | ||
|
||
}, [ | ||
"{%~state.com.adobe.module.lifecycle/lifecyclecontextdata.osversion%}", | ||
"testStringInsideNestedArray", | ||
null | ||
], | ||
null | ||
] | ||
} | ||
} | ||
} | ||
] | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we commit unformatted files earlier, or is there any change in Swift format version that we're using?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too sure how this happened. I just ran swiftformat locally and committed.