Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging -> Main - v1.6.0 Release - tvOS support #310

Merged
merged 8 commits into from
Mar 1, 2023
Merged

Staging -> Main - v1.6.0 Release - tvOS support #310

merged 8 commits into from
Mar 1, 2023

Conversation

addb
Copy link
Collaborator

@addb addb commented Mar 1, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

emdobrin and others added 8 commits October 19, 2022 20:35
Down merge to Dev after v1.5.0 release
* Add additional context for report suite ID

Update steps and clarify wording

* Update start podfile to comment out dependencies

* Update doc links and reword instruction text

* Update wording and formatting

* Remove cocoapods uninstall instructions

* Revert report suite info change
* [MOB-16628]  Full tvOS support (#255)

* [MOB-16628] Add targets and schemes to AEPEdge xcode project for tvOS support.

* [MOB-16628] Added and updated scripts for tvOS support

* [MOB-16628] Added tvOS testApp target and refactored the app.

* [MOB-16628] Update to Xcode 13

* Fix makefile

* [MOB-16628] Refactor testApp and script fixes

* Rearrange TestApp UI elements

* [MOB-16628] Update implementationDetails for tvOS

* Fix tests

* [MOB-16628] Update Package.swift

* Test cleanup

* Revert the min version for ios pods in test-podspec script

* Add min pod version for tvOS test project in test-podspec script

* Update test-podspec script

Co-authored-by: Emilia Dobrin <33132425+emdobrin@users.noreply.github.com>

* App fixes to support tvOS

* Get latest changes, import tvOS branch code for edgeConsent and edgeIdentity to test. Improved app code.

---------

Co-authored-by: Emilia Dobrin <33132425+emdobrin@users.noreply.github.com>
Co-authored-by: Kevin Lind <40409666+kevinlind@users.noreply.github.com>
* Create event reference mirrored from android

Types should reflect swift types
links updated to equivalent ios versions

* Update column name to required

* Update content

Fix null to nil
Update source to just responseContent like android

* Update iOS to reflect updated android revisions

separate api from event type and source
update links

* Add link to XDM

* Update grammar

* Update event data payload header wording

update dictionary types to use non breaking space to improve styling

* Update header capitalization

* Update headers to add content

* Update event dispatched by header

Update subsection ordering

* Add event type

* Update grammar to match android version

* Remove registerExtension API reference since it doesnt exist in iOS

Remove usage of AEP
Remove extra usage of Adobe Experience Platform
Update comment formatting
Update wording grammar to treat Edge Network as proper noun
Match wording and style from android version of doc

* Update grammar and style

Use Edge Network name
* Bump up version for tvOS release

* Update CI workflow, makefile and other scripts

* Do not run lint on tutorial apps

* Revert cache version
Dev -> Staging (tvOS support)
* Update to staging dependencies for tvOS changes

* Update edgeIdentity version in podspec

* Remove unwanted config.yml with theme from documentation folder

* Update edgeIdentity pod to production  version
@addb addb requested a review from kevinlind March 1, 2023 03:32
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #310 (359d116) into main (42fc356) will increase coverage by 1.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
+ Coverage   95.50%   96.54%   +1.04%     
==========================================
  Files          28       28              
  Lines        1045     1649     +604     
==========================================
+ Hits          998     1592     +594     
- Misses         47       57      +10     

@addb addb merged commit 5dfde80 into main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants