-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging -> Main - v1.6.0 Release - tvOS support #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Down merge to Dev after v1.5.0 release
Merging main -> dev
* Add additional context for report suite ID Update steps and clarify wording * Update start podfile to comment out dependencies * Update doc links and reword instruction text * Update wording and formatting * Remove cocoapods uninstall instructions * Revert report suite info change
* [MOB-16628] Full tvOS support (#255) * [MOB-16628] Add targets and schemes to AEPEdge xcode project for tvOS support. * [MOB-16628] Added and updated scripts for tvOS support * [MOB-16628] Added tvOS testApp target and refactored the app. * [MOB-16628] Update to Xcode 13 * Fix makefile * [MOB-16628] Refactor testApp and script fixes * Rearrange TestApp UI elements * [MOB-16628] Update implementationDetails for tvOS * Fix tests * [MOB-16628] Update Package.swift * Test cleanup * Revert the min version for ios pods in test-podspec script * Add min pod version for tvOS test project in test-podspec script * Update test-podspec script Co-authored-by: Emilia Dobrin <33132425+emdobrin@users.noreply.github.com> * App fixes to support tvOS * Get latest changes, import tvOS branch code for edgeConsent and edgeIdentity to test. Improved app code. --------- Co-authored-by: Emilia Dobrin <33132425+emdobrin@users.noreply.github.com> Co-authored-by: Kevin Lind <40409666+kevinlind@users.noreply.github.com>
* Create event reference mirrored from android Types should reflect swift types links updated to equivalent ios versions * Update column name to required * Update content Fix null to nil Update source to just responseContent like android * Update iOS to reflect updated android revisions separate api from event type and source update links * Add link to XDM * Update grammar * Update event data payload header wording update dictionary types to use non breaking space to improve styling * Update header capitalization * Update headers to add content * Update event dispatched by header Update subsection ordering * Add event type * Update grammar to match android version * Remove registerExtension API reference since it doesnt exist in iOS Remove usage of AEP Remove extra usage of Adobe Experience Platform Update comment formatting Update wording grammar to treat Edge Network as proper noun Match wording and style from android version of doc * Update grammar and style Use Edge Network name
* Bump up version for tvOS release * Update CI workflow, makefile and other scripts * Do not run lint on tutorial apps * Revert cache version
Dev -> Staging (tvOS support)
* Update to staging dependencies for tvOS changes * Update edgeIdentity version in podspec * Remove unwanted config.yml with theme from documentation folder * Update edgeIdentity pod to production version
Codecov Report
@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 95.50% 96.54% +1.04%
==========================================
Files 28 28
Lines 1045 1649 +604
==========================================
+ Hits 998 1592 +594
- Misses 47 57 +10 |
kevinlind
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: