Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for advertising identifier and adId consent collection #55

Merged
merged 66 commits into from
Jun 2, 2022

Commits on Jan 24, 2022

  1. Configuration menu
    Copy the full SHA
    1ea5966 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. Configuration menu
    Copy the full SHA
    efef862 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Configuration menu
    Copy the full SHA
    a2ee5f5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0006471 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. Migrate remaining test cases from original adID feature branch, and u…

    …pdate variables/classes to reflect naming convention changes
    timkimadobe committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    dfdcc16 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d8a3c42 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1 from adobe/feature-merge-advertising-id

    Feature merge advertising
    timkimadobe committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    7d06d83 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2b979e9 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. Update build script for SwiftLint to use PODS_ROOT path to check for …

    …executable
    
    Update IdentityConstants with proper values
    Update comments/documentation
    Update IdentityStateTests assertion data dictionary access to use IdentityConstants enum values
    Update copyright year to 2022 in new files
    Remove dev comments
    SwiftLint whitespace and indentation correction
    timkimadobe committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    1bd7efc View commit details
    Browse the repository at this point in the history
  2. Update test cases to handle existing AdID and no AdID with new AdID e…

    …vent and generic Identity event
    timkimadobe committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    07a1632 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. Add isAdIdEvent to Event+Identity extension and build in check to adI…

    …d retrieval
    
    Add isAdIdEvent check to handleRequestContent
    Simplify reset identities test case, remove persistedAdID all-zeros test case as there is no migration path to Edge Identity from this state
    timkimadobe committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    65d47ad View commit details
    Browse the repository at this point in the history
  2. Update Event+Identity extension with rationale for String type check …

    …in isAdIdEvent check
    
    Update documentation for adId
    timkimadobe committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    835a594 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2022

  1. Update test case to improve readability and preserve event order veri…

    …fication
    
    Update adId logic to only provide value sanitization
    timkimadobe committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    d73748f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2864ec8 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Configuration menu
    Copy the full SHA
    9cd040b View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Update naming conventions for test cases

    Implement functional tests for e2e testing
    timkimadobe committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    77393dc View commit details
    Browse the repository at this point in the history
  2. Simplify logical flow for detecting ad ID change

    Rename test file
    Add consent event type and source check, and format verification for testGenericIdentityRequest_whenValidAdId_thenEmptyAdId
    timkimadobe committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    8e7dda0 View commit details
    Browse the repository at this point in the history
  3. Remove outdated test case with all-zeros start

    Remove logging comments from test file
    timkimadobe committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    8d6854c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a34f6ae View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. Update adId type in Event extension to non-optional String

    Moved back shouldDispatchConsent check to original position, pending upstream service discussion
    timkimadobe committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    9fb04f0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1c5ea28 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Remove consent event dispatch from resetIdentifiers flow; the flows s…

    …hould be separate from each other
    timkimadobe committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    43c7f0d View commit details
    Browse the repository at this point in the history
  2. Remove consent event check from resetIdentity test; consent is not lo…

    …nger handled as part of the reset flow
    timkimadobe committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    a164026 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f2d1821 View commit details
    Browse the repository at this point in the history
  4. Migrating adID feature branch to current dev branch (#52)

    * WIP merge with current dev branch
    
    * update enum usage to reflect updated naming scheme
    
    * migrate tests from old feature branch, add new files to test targets
    
    * Update TestableExtensionRuntime to include new method required by ExtensionRuntime protocol
    
    * Migrate remaining test cases from original adID feature branch, and update variables/classes to reflect naming convention changes
    
    * Migrate IdentityTest cases
    
    * Remove commented code and extra spaces
    
    * Update build script for SwiftLint to use PODS_ROOT path to check for executable
    Update IdentityConstants with proper values
    Update comments/documentation
    Update IdentityStateTests assertion data dictionary access to use IdentityConstants enum values
    Update copyright year to 2022 in new files
    Remove dev comments
    SwiftLint whitespace and indentation correction
    
    * Update test cases to handle existing AdID and no AdID with new AdID event and generic Identity event
    
    * Add isAdIdEvent to Event+Identity extension and build in check to adId retrieval
    Add isAdIdEvent check to handleRequestContent
    Simplify reset identities test case, remove persistedAdID all-zeros test case as there is no migration path to Edge Identity from this state
    
    * Update Event+Identity extension with rationale for String type check in isAdIdEvent check
    Update documentation for adId
    
    * Update test case to improve readability and preserve event order verification
    Update adId logic to only provide value sanitization
    
    * Remove outdated test for nil adID using direct state.updateAdvertisingIdentifier
    
    * Removing public access status for Event+Identity extension property
    
    * Update naming conventions for test cases
    Implement functional tests for e2e testing
    
    * Simplify logical flow for detecting ad ID change
    Rename test file
    Add consent event type and source check, and format verification for testGenericIdentityRequest_whenValidAdId_thenEmptyAdId
    
    * Remove outdated test case with all-zeros start
    Remove logging comments from test file
    
    * Move consent event dispatch to before resetting ECID; should send consent with old ECID
    
    * Update adId type in Event extension to non-optional String
    Moved back shouldDispatchConsent check to original position, pending upstream service discussion
    
    * Remove nil coalescing operator for adId after its update to non-optional String
    
    * Remove consent event dispatch from resetIdentifiers flow; the flows should be separate from each other
    
    * Remove consent event check from resetIdentity test; consent is not longer handled as part of the reset flow
    
    * Update test comments and remove commented case
    timkimadobe committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    8c8ffb1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b33c132 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. Update IdentityAdIDTests with helper functions to reduce boilerplate

    Update comments to better reflect test case goals
    Update test cases to use variables to store test strings
    Update naming convention of ad ID value from old -> initial
    timkimadobe committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    e471ed4 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Update test app to use real IDFA flow to update consent and ad ID

    Update required pods for test app target adding: Edge & Edge Consent
    Add NSUserTrackingUsageDescription to test app plist
    timkimadobe committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    a42e86b View commit details
    Browse the repository at this point in the history
  2. Removing launch file ID

    timkimadobe committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    ca93d89 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. Update consent to be for ad ID consent instead of "collect"

    Add get current consent button
    Update comment and logs to be more accurate
    timkimadobe committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    c5f7062 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1767cee View commit details
    Browse the repository at this point in the history
  3. Remove manual consent update flow as it is handled by the ad ID event…

    … listener automatically
    
    Update comments to help user set ad ID properly in the simulator case
    timkimadobe committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    0ffcde8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d2a7743 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. Update test helper access level and logic

    Remove unused code in test app
    timkimadobe committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    d7c8f3c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d4ba29c View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Add test coverage cases

    timkimadobe committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    93e29e3 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #54 from timkimadobe/feature/adIdConsent

    Update Test App to use real IDFA flow for ad ID changes
    timkimadobe committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    e1d6192 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Configuration menu
    Copy the full SHA
    ff3b664 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0892ed9 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Configuration menu
    Copy the full SHA
    819254a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ab5890d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba229ee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    80f8bea View commit details
    Browse the repository at this point in the history
  5. Merge pull request #56 from timkimadobe/feature/adIdConsent

    Adding log for trying to update identifiers for ad ID reserved namespaces
    timkimadobe committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    9634424 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. Configuration menu
    Copy the full SHA
    77489be View commit details
    Browse the repository at this point in the history
  2. Resolve merge conflicts

    emdobrin committed May 9, 2022
    Configuration menu
    Copy the full SHA
    61c84c8 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Merge pull request #66 from emdobrin/feature/adIdConsent

    Merge latest dev changes -> feature/adidConsent
    emdobrin committed May 11, 2022
    Configuration menu
    Copy the full SHA
    1e14fe7 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. Updated test dependencies (#67)

    * Updated dependencies, using staging changes for Edge
    
    * Update testableExtensionRuntime for latest core
    
    * Renaming for environment field
    
    * CircleCI - update to Xcode 12
    
    * Consent 1.0.0
    emdobrin committed May 12, 2022
    Configuration menu
    Copy the full SHA
    b7a7939 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. Configuration menu
    Copy the full SHA
    fe0ba26 View commit details
    Browse the repository at this point in the history
  2. Update requestTrackingAuthorization function to be pure request track…

    …ing flow; other functionality is handled by other methods in the util class
    timkimadobe committed May 19, 2022
    Configuration menu
    Copy the full SHA
    696b0d7 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'feature/adIdConsent' into feature/ad-id-consent

    # Conflicts:
    #	Podfile.lock
    #	SampleApps/TestApp/ContentView.swift
    timkimadobe committed May 19, 2022
    Configuration menu
    Copy the full SHA
    8d0c556 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6e26763 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7501681 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    98ba529 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. Configuration menu
    Copy the full SHA
    a6d77f6 View commit details
    Browse the repository at this point in the history
  2. Update logical flow for setting ad ID to check for tracking authoriza…

    …tion and set the value accordingly
    timkimadobe committed May 20, 2022
    Configuration menu
    Copy the full SHA
    ed0731d View commit details
    Browse the repository at this point in the history
  3. Update ad ID consent to align with sample app implementation (#69)

    * Update ad ID view to use ad ID utils and better align with sample app implementation
    
    * Update requestTrackingAuthorization function to be pure request tracking flow; other functionality is handled by other methods in the util class
    
    * Remove get ad ID in request flow; use get ad ID flow instead to fetch or print value
    
    * Update documentation wording to defer to apple docs
    
    * Update documentation to reflect iOS version verbiage
    
    * Updating podfile.lock to use staging
    
    * Update logical flow for setting ad ID to check for tracking authorization and set the value accordingly
    timkimadobe committed May 20, 2022
    Configuration menu
    Copy the full SHA
    93968fc View commit details
    Browse the repository at this point in the history

Commits on May 23, 2022

  1. Configuration menu
    Copy the full SHA
    e52d874 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'feature/adIdConsent' into feature/ad-id-consent

    # Conflicts:
    #	AEPEdgeIdentity.xcodeproj/project.pbxproj
    timkimadobe committed May 23, 2022
    Configuration menu
    Copy the full SHA
    007ade7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c2cad4f View commit details
    Browse the repository at this point in the history
  4. Remove TestApp App SwiftUI initialization file (replaced with app + s…

    …cene delegates)
    
    Apply swiftlint autocorrect and update Button closure syntax to avoid trailing closure violation
    timkimadobe committed May 23, 2022
    Configuration menu
    Copy the full SHA
    5145e01 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2a2d323 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    aedef05 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Merge pull request #70 from timkimadobe/feature/ad-id-consent

    Update Swift Test App for iOS 13 compatibility
    timkimadobe committed May 24, 2022
    Configuration menu
    Copy the full SHA
    1e9c5a2 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Select test scheme from xcodeproj (#71)

    * Select test scheme from xcodeproj
    
    * Select project scheme from xcworkspace
    
    * Update test command to use conditional scheme name based on presence of project name conflict or not
    
    * Update name conflict case paren string to use EXTENSION_NAME instead of PROJECT_NAME
    
    * Update scheme variables to appropriate sources
    
    Co-authored-by: Tim Kim <95260439+timkimadobe@users.noreply.github.com>
    emdobrin and timkimadobe committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    9247e6e View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Configuration menu
    Copy the full SHA
    7f6820e View commit details
    Browse the repository at this point in the history