-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for advertising identifier and adId consent collection #55
Commits on Jan 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1ea5966 - Browse repository at this point
Copy the full SHA 1ea5966View commit details
Commits on Jan 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for efef862 - Browse repository at this point
Copy the full SHA efef862View commit details
Commits on Jan 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a2ee5f5 - Browse repository at this point
Copy the full SHA a2ee5f5View commit details -
Update TestableExtensionRuntime to include new method required by Ext…
…ensionRuntime protocol
Configuration menu - View commit details
-
Copy full SHA for 0006471 - Browse repository at this point
Copy the full SHA 0006471View commit details
Commits on Jan 27, 2022
-
Migrate remaining test cases from original adID feature branch, and u…
…pdate variables/classes to reflect naming convention changes
Configuration menu - View commit details
-
Copy full SHA for dfdcc16 - Browse repository at this point
Copy the full SHA dfdcc16View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8a3c42 - Browse repository at this point
Copy the full SHA d8a3c42View commit details -
Merge pull request #1 from adobe/feature-merge-advertising-id
Feature merge advertising
Configuration menu - View commit details
-
Copy full SHA for 7d06d83 - Browse repository at this point
Copy the full SHA 7d06d83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b979e9 - Browse repository at this point
Copy the full SHA 2b979e9View commit details
Commits on Jan 28, 2022
-
Update build script for SwiftLint to use PODS_ROOT path to check for …
…executable Update IdentityConstants with proper values Update comments/documentation Update IdentityStateTests assertion data dictionary access to use IdentityConstants enum values Update copyright year to 2022 in new files Remove dev comments SwiftLint whitespace and indentation correction
Configuration menu - View commit details
-
Copy full SHA for 1bd7efc - Browse repository at this point
Copy the full SHA 1bd7efcView commit details -
Update test cases to handle existing AdID and no AdID with new AdID e…
…vent and generic Identity event
Configuration menu - View commit details
-
Copy full SHA for 07a1632 - Browse repository at this point
Copy the full SHA 07a1632View commit details
Commits on Feb 4, 2022
-
Add isAdIdEvent to Event+Identity extension and build in check to adI…
…d retrieval Add isAdIdEvent check to handleRequestContent Simplify reset identities test case, remove persistedAdID all-zeros test case as there is no migration path to Edge Identity from this state
Configuration menu - View commit details
-
Copy full SHA for 65d47ad - Browse repository at this point
Copy the full SHA 65d47adView commit details -
Update Event+Identity extension with rationale for String type check …
…in isAdIdEvent check Update documentation for adId
Configuration menu - View commit details
-
Copy full SHA for 835a594 - Browse repository at this point
Copy the full SHA 835a594View commit details
Commits on Feb 5, 2022
-
Update test case to improve readability and preserve event order veri…
…fication Update adId logic to only provide value sanitization
Configuration menu - View commit details
-
Copy full SHA for d73748f - Browse repository at this point
Copy the full SHA d73748fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2864ec8 - Browse repository at this point
Copy the full SHA 2864ec8View commit details
Commits on Feb 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9cd040b - Browse repository at this point
Copy the full SHA 9cd040bView commit details
Commits on Feb 8, 2022
-
Update naming conventions for test cases
Implement functional tests for e2e testing
Configuration menu - View commit details
-
Copy full SHA for 77393dc - Browse repository at this point
Copy the full SHA 77393dcView commit details -
Simplify logical flow for detecting ad ID change
Rename test file Add consent event type and source check, and format verification for testGenericIdentityRequest_whenValidAdId_thenEmptyAdId
Configuration menu - View commit details
-
Copy full SHA for 8e7dda0 - Browse repository at this point
Copy the full SHA 8e7dda0View commit details -
Remove outdated test case with all-zeros start
Remove logging comments from test file
Configuration menu - View commit details
-
Copy full SHA for 8d6854c - Browse repository at this point
Copy the full SHA 8d6854cView commit details -
Move consent event dispatch to before resetting ECID; should send con…
…sent with old ECID
Configuration menu - View commit details
-
Copy full SHA for a34f6ae - Browse repository at this point
Copy the full SHA a34f6aeView commit details
Commits on Feb 9, 2022
-
Update adId type in Event extension to non-optional String
Moved back shouldDispatchConsent check to original position, pending upstream service discussion
Configuration menu - View commit details
-
Copy full SHA for 9fb04f0 - Browse repository at this point
Copy the full SHA 9fb04f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c5ea28 - Browse repository at this point
Copy the full SHA 1c5ea28View commit details
Commits on Feb 10, 2022
-
Remove consent event dispatch from resetIdentifiers flow; the flows s…
…hould be separate from each other
Configuration menu - View commit details
-
Copy full SHA for 43c7f0d - Browse repository at this point
Copy the full SHA 43c7f0dView commit details -
Remove consent event check from resetIdentity test; consent is not lo…
…nger handled as part of the reset flow
Configuration menu - View commit details
-
Copy full SHA for a164026 - Browse repository at this point
Copy the full SHA a164026View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2d1821 - Browse repository at this point
Copy the full SHA f2d1821View commit details -
Migrating adID feature branch to current dev branch (#52)
* WIP merge with current dev branch * update enum usage to reflect updated naming scheme * migrate tests from old feature branch, add new files to test targets * Update TestableExtensionRuntime to include new method required by ExtensionRuntime protocol * Migrate remaining test cases from original adID feature branch, and update variables/classes to reflect naming convention changes * Migrate IdentityTest cases * Remove commented code and extra spaces * Update build script for SwiftLint to use PODS_ROOT path to check for executable Update IdentityConstants with proper values Update comments/documentation Update IdentityStateTests assertion data dictionary access to use IdentityConstants enum values Update copyright year to 2022 in new files Remove dev comments SwiftLint whitespace and indentation correction * Update test cases to handle existing AdID and no AdID with new AdID event and generic Identity event * Add isAdIdEvent to Event+Identity extension and build in check to adId retrieval Add isAdIdEvent check to handleRequestContent Simplify reset identities test case, remove persistedAdID all-zeros test case as there is no migration path to Edge Identity from this state * Update Event+Identity extension with rationale for String type check in isAdIdEvent check Update documentation for adId * Update test case to improve readability and preserve event order verification Update adId logic to only provide value sanitization * Remove outdated test for nil adID using direct state.updateAdvertisingIdentifier * Removing public access status for Event+Identity extension property * Update naming conventions for test cases Implement functional tests for e2e testing * Simplify logical flow for detecting ad ID change Rename test file Add consent event type and source check, and format verification for testGenericIdentityRequest_whenValidAdId_thenEmptyAdId * Remove outdated test case with all-zeros start Remove logging comments from test file * Move consent event dispatch to before resetting ECID; should send consent with old ECID * Update adId type in Event extension to non-optional String Moved back shouldDispatchConsent check to original position, pending upstream service discussion * Remove nil coalescing operator for adId after its update to non-optional String * Remove consent event dispatch from resetIdentifiers flow; the flows should be separate from each other * Remove consent event check from resetIdentity test; consent is not longer handled as part of the reset flow * Update test comments and remove commented case
Configuration menu - View commit details
-
Copy full SHA for 8c8ffb1 - Browse repository at this point
Copy the full SHA 8c8ffb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b33c132 - Browse repository at this point
Copy the full SHA b33c132View commit details
Commits on Feb 11, 2022
-
Update IdentityAdIDTests with helper functions to reduce boilerplate
Update comments to better reflect test case goals Update test cases to use variables to store test strings Update naming convention of ad ID value from old -> initial
Configuration menu - View commit details
-
Copy full SHA for e471ed4 - Browse repository at this point
Copy the full SHA e471ed4View commit details
Commits on Feb 16, 2022
-
Update test app to use real IDFA flow to update consent and ad ID
Update required pods for test app target adding: Edge & Edge Consent Add NSUserTrackingUsageDescription to test app plist
Configuration menu - View commit details
-
Copy full SHA for a42e86b - Browse repository at this point
Copy the full SHA a42e86bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca93d89 - Browse repository at this point
Copy the full SHA ca93d89View commit details
Commits on Mar 4, 2022
-
Update consent to be for ad ID consent instead of "collect"
Add get current consent button Update comment and logs to be more accurate
Configuration menu - View commit details
-
Copy full SHA for c5f7062 - Browse repository at this point
Copy the full SHA c5f7062View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1767cee - Browse repository at this point
Copy the full SHA 1767ceeView commit details -
Remove manual consent update flow as it is handled by the ad ID event…
… listener automatically Update comments to help user set ad ID properly in the simulator case
Configuration menu - View commit details
-
Copy full SHA for 0ffcde8 - Browse repository at this point
Copy the full SHA 0ffcde8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2a7743 - Browse repository at this point
Copy the full SHA d2a7743View commit details
Commits on Mar 7, 2022
-
Update test helper access level and logic
Remove unused code in test app
Configuration menu - View commit details
-
Copy full SHA for d7c8f3c - Browse repository at this point
Copy the full SHA d7c8f3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d4ba29c - Browse repository at this point
Copy the full SHA d4ba29cView commit details
Commits on Mar 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 93e29e3 - Browse repository at this point
Copy the full SHA 93e29e3View commit details -
Merge pull request #54 from timkimadobe/feature/adIdConsent
Update Test App to use real IDFA flow for ad ID changes
Configuration menu - View commit details
-
Copy full SHA for e1d6192 - Browse repository at this point
Copy the full SHA e1d6192View commit details
Commits on Mar 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ff3b664 - Browse repository at this point
Copy the full SHA ff3b664View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0892ed9 - Browse repository at this point
Copy the full SHA 0892ed9View commit details
Commits on Mar 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 819254a - Browse repository at this point
Copy the full SHA 819254aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab5890d - Browse repository at this point
Copy the full SHA ab5890dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba229ee - Browse repository at this point
Copy the full SHA ba229eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 80f8bea - Browse repository at this point
Copy the full SHA 80f8beaView commit details -
Merge pull request #56 from timkimadobe/feature/adIdConsent
Adding log for trying to update identifiers for ad ID reserved namespaces
Configuration menu - View commit details
-
Copy full SHA for 9634424 - Browse repository at this point
Copy the full SHA 9634424View commit details
Commits on May 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 77489be - Browse repository at this point
Copy the full SHA 77489beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61c84c8 - Browse repository at this point
Copy the full SHA 61c84c8View commit details
Commits on May 11, 2022
-
Merge pull request #66 from emdobrin/feature/adIdConsent
Merge latest dev changes -> feature/adidConsent
Configuration menu - View commit details
-
Copy full SHA for 1e14fe7 - Browse repository at this point
Copy the full SHA 1e14fe7View commit details
Commits on May 12, 2022
-
Updated test dependencies (#67)
* Updated dependencies, using staging changes for Edge * Update testableExtensionRuntime for latest core * Renaming for environment field * CircleCI - update to Xcode 12 * Consent 1.0.0
Configuration menu - View commit details
-
Copy full SHA for b7a7939 - Browse repository at this point
Copy the full SHA b7a7939View commit details
Commits on May 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fe0ba26 - Browse repository at this point
Copy the full SHA fe0ba26View commit details -
Update requestTrackingAuthorization function to be pure request track…
…ing flow; other functionality is handled by other methods in the util class
Configuration menu - View commit details
-
Copy full SHA for 696b0d7 - Browse repository at this point
Copy the full SHA 696b0d7View commit details -
Merge branch 'feature/adIdConsent' into feature/ad-id-consent
# Conflicts: # Podfile.lock # SampleApps/TestApp/ContentView.swift
Configuration menu - View commit details
-
Copy full SHA for 8d0c556 - Browse repository at this point
Copy the full SHA 8d0c556View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e26763 - Browse repository at this point
Copy the full SHA 6e26763View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7501681 - Browse repository at this point
Copy the full SHA 7501681View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98ba529 - Browse repository at this point
Copy the full SHA 98ba529View commit details
Commits on May 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a6d77f6 - Browse repository at this point
Copy the full SHA a6d77f6View commit details -
Update logical flow for setting ad ID to check for tracking authoriza…
…tion and set the value accordingly
Configuration menu - View commit details
-
Copy full SHA for ed0731d - Browse repository at this point
Copy the full SHA ed0731dView commit details -
Update ad ID consent to align with sample app implementation (#69)
* Update ad ID view to use ad ID utils and better align with sample app implementation * Update requestTrackingAuthorization function to be pure request tracking flow; other functionality is handled by other methods in the util class * Remove get ad ID in request flow; use get ad ID flow instead to fetch or print value * Update documentation wording to defer to apple docs * Update documentation to reflect iOS version verbiage * Updating podfile.lock to use staging * Update logical flow for setting ad ID to check for tracking authorization and set the value accordingly
Configuration menu - View commit details
-
Copy full SHA for 93968fc - Browse repository at this point
Copy the full SHA 93968fcView commit details
Commits on May 23, 2022
-
Update Swift test app to use app + scene delegate initialization for …
…iOS 13 compatibility
Configuration menu - View commit details
-
Copy full SHA for e52d874 - Browse repository at this point
Copy the full SHA e52d874View commit details -
Merge branch 'feature/adIdConsent' into feature/ad-id-consent
# Conflicts: # AEPEdgeIdentity.xcodeproj/project.pbxproj
Configuration menu - View commit details
-
Copy full SHA for 007ade7 - Browse repository at this point
Copy the full SHA 007ade7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2cad4f - Browse repository at this point
Copy the full SHA c2cad4fView commit details -
Remove TestApp App SwiftUI initialization file (replaced with app + s…
…cene delegates) Apply swiftlint autocorrect and update Button closure syntax to avoid trailing closure violation
Configuration menu - View commit details
-
Copy full SHA for 5145e01 - Browse repository at this point
Copy the full SHA 5145e01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a2d323 - Browse repository at this point
Copy the full SHA 2a2d323View commit details -
Configuration menu - View commit details
-
Copy full SHA for aedef05 - Browse repository at this point
Copy the full SHA aedef05View commit details
Commits on May 24, 2022
-
Merge pull request #70 from timkimadobe/feature/ad-id-consent
Update Swift Test App for iOS 13 compatibility
Configuration menu - View commit details
-
Copy full SHA for 1e9c5a2 - Browse repository at this point
Copy the full SHA 1e9c5a2View commit details
Commits on Jun 1, 2022
-
Select test scheme from xcodeproj (#71)
* Select test scheme from xcodeproj * Select project scheme from xcworkspace * Update test command to use conditional scheme name based on presence of project name conflict or not * Update name conflict case paren string to use EXTENSION_NAME instead of PROJECT_NAME * Update scheme variables to appropriate sources Co-authored-by: Tim Kim <95260439+timkimadobe@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 9247e6e - Browse repository at this point
Copy the full SHA 9247e6eView commit details
Commits on Jun 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7f6820e - Browse repository at this point
Copy the full SHA 7f6820eView commit details