Merge latest dev changes -> feature/adidConsent #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update docs for IdentityMap.swift
…eCustomerIdentifers or removeCustomerIdentifers are called.
…lears the identity map.
[MOB-16019] Set pending state before updating IdentityMap
Bump up version for v1.0.1 release
Dev -> Staging (v1.01)
Staging -> Main (v1.0.1)
Bumps [cocoapods-downloader](https://github.com/CocoaPods/cocoapods-downloader) from 1.4.0 to 1.6.3. - [Release notes](https://github.com/CocoaPods/cocoapods-downloader/releases) - [Changelog](https://github.com/CocoaPods/cocoapods-downloader/blob/master/CHANGELOG.md) - [Commits](CocoaPods/cocoapods-downloader@1.4.0...1.6.3) --- updated-dependencies: - dependency-name: cocoapods-downloader dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
merge main -> dev after v1.0.1 release
* Release Drafter Draft Release tool allows for creating draft releases (and real releases if desired), using a separate config from the full repo release flow Documentation for how to use the release drafter tool is also included * Update config to only include explicitly labeled PRs, full changelog link at the bottom Update documentation to reflect feedback and updated output style Remove draft-specific config, and draft tool points to actual changelog config (same as prd) * Update documentation for release drafter: header levels and some text updates Update release drafter config to create Enhancements category and remove redundant bug-type labels
Codecov Report
@@ Coverage Diff @@
## feature/adIdConsent #66 +/- ##
=======================================================
+ Coverage 95.22% 97.00% +1.77%
=======================================================
Files 7 7
Lines 314 333 +19
=======================================================
+ Hits 299 323 +24
+ Misses 15 10 -5 |
emdobrin
commented
May 9, 2022
Comment on lines
+243
to
253
| /// Save `identityProperties` to persistence and resolves the XDM shared state. | ||
| /// - Parameters: | ||
| /// - resolveXDMSharedState: function which resolves the XDM shared state | ||
| private func saveToPersistence(and resolveXDMSharedState: ([String: Any]) -> Void) { | ||
| identityProperties.saveToPersistence() | ||
| resolveXDMSharedState(identityProperties.toXdmData()) | ||
| } | ||
|
|
||
| /// Save `identityProperties` to persistence and create an XDM shared state. | ||
| /// - Parameters: | ||
| /// - createXDMSharedState: function which creates an XDM shared state |
There was a problem hiding this comment.
The only change in this PR other than the changes from dev is that this function is added back:
private func saveToPersistence(and createXDMSharedState: ([String: Any], Event) -> Void, using event: Event)
In dev the update identity APIs use pending shared state and resolver. If adid does not change when setAdvertisingIdentifier API, I think we should not create a pending shared state and resolve with the same data, but just create a new shared state when the value changed.
There was a problem hiding this comment.
I hope we dont see the same race condition for adId then in case setAdId and getAdId being called back to back.
There was a problem hiding this comment.
There is no getAdid, but you can call getIdentities. For the consent use-case the shared state is updated first, then the consent -> edge events are being dispatched, so the data should be up to date at processing time.
cacheung
approved these changes
May 10, 2022
addb
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: