Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add proxy support #480

Merged
merged 19 commits into from
Oct 6, 2021
Merged

feat: add proxy support #480

merged 19 commits into from
Oct 6, 2021

Conversation

shazron
Copy link
Member

@shazron shazron commented Sep 22, 2021

Fixes #472

Dependencies

  • update adobe/aio-lib-runtime to final released version
  • update adobe/aio-lib-cli-console to final released version
  • update adobe/aio-lib-core-networking to final released version
  • update adobe/aio-lib-ims to final released version

Before merge

  • update Dependencies (see above)
  • do one final next tag release
  • revert package.json version to master branch package.json version

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #480 (18d72a7) into master (0ad20f2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #480   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines         2260      2262    +2     
  Branches       375       375           
=========================================
+ Hits          2260      2262    +2     
Impacted Files Coverage Δ
src/lib/app-helper.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad20f2...18d72a7. Read the comment docs.

@shazron shazron marked this pull request as ready for review September 28, 2021 11:38
@shazron shazron changed the title WIP feat: add proxy support feat: add proxy support Sep 28, 2021
shazron and others added 3 commits September 29, 2021 11:23
1. adobe/generator-aio-app
2. adobe/generator-aio-console
3. adobe/aio-lib-runtime
4. adobe/aio-lib-core-networking
5. adobe/aio-lib-web
@shazron shazron marked this pull request as draft September 29, 2021 04:04
@shazron shazron closed this Sep 29, 2021
@shazron shazron reopened this Sep 29, 2021
@shazron shazron closed this Sep 30, 2021
@shazron shazron reopened this Sep 30, 2021
@shazron shazron marked this pull request as ready for review October 6, 2021 04:17
@shazron
Copy link
Member Author

shazron commented Oct 6, 2021

Do not merge until Dependencies section is complete and tests pass after.

@shazron shazron merged commit d69a0e4 into master Oct 6, 2021
@shazron shazron deleted the proxy-support branch October 6, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add proxy support
2 participants