Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add proxy support #85

Merged
merged 11 commits into from
Oct 6, 2021
Merged

feat: add proxy support #85

merged 11 commits into from
Oct 6, 2021

Conversation

shazron
Copy link
Member

@shazron shazron commented Sep 22, 2021

Fixes #83

Dependencies

Dependents (update references in the PRs when this is merged in to master)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #85 (49322d1) into master (a714a7a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #85   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          420       421    +1     
  Branches        51        51           
=========================================
+ Hits           420       421    +1     
Impacted Files Coverage Δ
src/ims.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a714a7a...49322d1. Read the comment docs.

@shazron shazron changed the title WIP feat: add proxy support feat: add proxy support Sep 29, 2021
@shazron shazron marked this pull request as ready for review October 6, 2021 04:49
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shazron shazron merged commit 90d5dd9 into master Oct 6, 2021
@shazron shazron deleted the proxy-support branch October 6, 2021 09:48
@shazron shazron restored the proxy-support branch October 6, 2021 10:06
@shazron shazron deleted the proxy-support branch October 6, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add proxy support
2 participants