Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling and refactoring pre-undeploy-event-reg hook implementation #694

Merged
merged 6 commits into from
Jul 20, 2023

Conversation

sangeetha5491
Copy link
Contributor

@sangeetha5491 sangeetha5491 commented Jul 14, 2023

Description

Earlier , on aio app undeploy, if no actions were deployed, but the associated event registrations were still present, it would not undeploy the event registrations. This could happen if the actions were successfully undeployed but the event registrations failed.

This change fixes that behavior, by separating the events hook being called prior to the actions being undeployed.

Also, i have removed the post-deploy hook ( since i dont see a need right now, and can be added when required ) and added error handling to the pre-undeploy-events-reg

Related Issue

Blocks

Motivation and Context

handle undeploy for event registrations by calling the pre-undeploy-events-reg hook

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sangeetha5491 sangeetha5491 marked this pull request as draft July 14, 2023 07:35
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #694 (ae06a93) into master (b9cf971) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #694   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3148      3146    -2     
  Branches       587       587           
=========================================
- Hits          3148      3146    -2     
Impacted Files Coverage Δ
src/commands/app/undeploy.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sangeetha5491 sangeetha5491 marked this pull request as ready for review July 14, 2023 14:25
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok lgtm makes sense to separate the events processing from the actions

Copy link
Member

@purplecabbage purplecabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sangeetha5491 sangeetha5491 merged commit 251f7bb into master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants