-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling and refactoring pre-undeploy-event-reg hook implementation #694
Conversation
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 3148 3146 -2
Branches 587 587
=========================================
- Hits 3148 3146 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok lgtm makes sense to separate the events processing from the actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
Earlier , on aio app undeploy, if no actions were deployed, but the associated event registrations were still present, it would not undeploy the event registrations. This could happen if the actions were successfully undeployed but the event registrations failed.
This change fixes that behavior, by separating the events hook being called prior to the actions being undeployed.
Also, i have removed the post-deploy hook ( since i dont see a need right now, and can be added when required ) and added error handling to the pre-undeploy-events-reg
Related Issue
Blocks
Motivation and Context
handle undeploy for event registrations by calling the pre-undeploy-events-reg hook
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: