Implement pre-undeploy-event-reg hook to undeploy event registrations #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 25 +1
Lines 611 633 +22
Branches 82 87 +5
=========================================
+ Hits 611 633 +22
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
10 tasks
purplecabbage
approved these changes
Jul 20, 2023
src/hooks/utils/hook-utils.js
Outdated
| * @param {object} appConfigRoot.appConfig - Object containing events and project details | ||
| * @param {object} appConfigRoot.appConfig.project - Project details from the .aio file | ||
| * @param {object} appConfigRoot.appConfig.events - Events registrations that are part of the app.config.yaml file | ||
| * @param {string} hookType - pre-deploy-event-reg or post-deploy-event-reg hook values |
There was a problem hiding this comment.
I don't think you need this anymore ...
There was a problem hiding this comment.
hookType that is, since its always gonna be pre-deploy-event-reg now ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Undeploy event registrations in the pre-undeploy-event-reg hook
Related Issue
Is Blocked By
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: